Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCO-401: Add azure-workload-identity-webhook to image references. #586

Merged
merged 1 commit into from Aug 4, 2023

Conversation

abutcher
Copy link
Member

@abutcher abutcher commented Aug 1, 2023

Per https://docs.ci.openshift.org/docs/how-tos/onboarding-a-new-component/#product-builds-and-becoming-part-of-an-openshift-release-image the image must be listed in an image references file to be picked up by CI nightlies.

  1. Operands managed by second level operators. These images are pulled into the release payload by virtue of being specified in an image-references file by a second level operator.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 1, 2023

@abutcher: This pull request references CCO-401 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 1, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 1, 2023

@abutcher: This pull request references CCO-401 which is a valid jira issue.

In response to this:

Per https://docs.ci.openshift.org/docs/how-tos/onboarding-a-new-component/#product-builds-and-becoming-part-of-an-openshift-release-image the image must be listed in an image references file to be picked up by CI nightlies.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 1, 2023

@abutcher: This pull request references CCO-401 which is a valid jira issue.

In response to this:

Per https://docs.ci.openshift.org/docs/how-tos/onboarding-a-new-component/#product-builds-and-becoming-part-of-an-openshift-release-image the image must be listed in an image references file to be picked up by CI nightlies.

  1. Operands managed by second level operators. These images are pulled into the release payload by virtue of being specified in an image-references file by a second level operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abutcher
Copy link
Member Author

abutcher commented Aug 1, 2023

/assign @jstuever

@abutcher abutcher changed the title CCO-401: Add azure-pod-identity-webhook to image references. CCO-401: Add azure-workload-identity-webhook to image references. Aug 1, 2023
@abutcher
Copy link
Member Author

abutcher commented Aug 1, 2023

Hold for confirmation on the quay link, etc.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2023
@jstuever
Copy link
Contributor

jstuever commented Aug 1, 2023

depends on openshift/release#41878

@abutcher
Copy link
Member Author

abutcher commented Aug 4, 2023

/test images

@abutcher
Copy link
Member Author

abutcher commented Aug 4, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2023
@jstuever
Copy link
Contributor

jstuever commented Aug 4, 2023

/retest

@jstuever
Copy link
Contributor

jstuever commented Aug 4, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2023

@abutcher: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 23aa52b into openshift:master Aug 4, 2023
8 checks passed
@abutcher abutcher deleted the CCO-401 branch August 5, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants