Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCO-401: Include azure-workload-identity images configuration. #41878

Merged
merged 1 commit into from Aug 3, 2023

Conversation

abutcher
Copy link
Member

@abutcher abutcher commented Aug 1, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 1, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 1, 2023

@abutcher: This pull request references CCO-401 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abutcher
Copy link
Member Author

abutcher commented Aug 1, 2023

/pj-rehearse

@openshift-ci openshift-ci bot requested review from dlom and jstuever August 1, 2023 20:01
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@abutcher: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-azure-workload-identity-main-e2e-azure openshift/azure-workload-identity presubmit Presubmit changed
pull-ci-openshift-azure-workload-identity-main-images openshift/azure-workload-identity presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@abutcher
Copy link
Member Author

abutcher commented Aug 1, 2023

/pj-rehearse

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2023

@abutcher: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/azure-workload-identity/main/e2e-azure 2374a26 link unknown /pj-rehearse pull-ci-openshift-azure-workload-identity-main-e2e-azure
ci/rehearse/openshift/azure-workload-identity/main/images 2374a26 link unknown /pj-rehearse pull-ci-openshift-azure-workload-identity-main-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jstuever
Copy link
Contributor

jstuever commented Aug 1, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@abutcher
Copy link
Member Author

abutcher commented Aug 1, 2023

/assign @dhellmann

The target repo doesn't yet have a .ci-operator.yaml config but I think it gets automatically created by the CI robot based on other history.

@jstuever jstuever removed their assignment Aug 1, 2023
@dhellmann
Copy link
Contributor

/approve

The name azure-workload-identity-webhook looks good to me.

@abutcher
Copy link
Member Author

abutcher commented Aug 3, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, dhellmann, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit a88f99a into openshift:master Aug 3, 2023
18 of 20 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2023

@abutcher: Updated the following 4 configmaps:

  • ci-operator-main-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-azure-workload-identity-main.yaml using file ci-operator/config/openshift/azure-workload-identity/openshift-azure-workload-identity-main.yaml
  • job-config-main-postsubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-azure-workload-identity-main-postsubmits.yaml using file ci-operator/jobs/openshift/azure-workload-identity/openshift-azure-workload-identity-main-postsubmits.yaml
  • job-config-main-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-azure-workload-identity-main-presubmits.yaml using file ci-operator/jobs/openshift/azure-workload-identity/openshift-azure-workload-identity-main-presubmits.yaml
  • image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:
    • key mapping_origin_4_14 using file core-services/image-mirroring/openshift/mapping_origin_4_14

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abutcher abutcher deleted the CCO-401 branch August 3, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
5 participants