[release-4.14] OCPBUGS-37823: GCP passthrough permissions check to ignore problematic permissions. #741

openshift-cherrypick-robot · 2024-08-01T14:51:34Z

This is an automated cherry-pick of #730

/assign openshift-cherrypick-robot

Currently, the GCP passthrough permissions check generates a list of required permissions from the credential requests, queries and caches a list of valid permissions for the project, filters the required list to only include those that are valid, and then ensures the provided service account has the filtered list of permissions on the project. However, for whatever reason, sometimes the check errors stating that the permission is invalid. This change attempts to discover when this happens and removes the problematic permission from the cached list of valid permissions. This enables the check to function properly for the remaining duration of the cache.

openshift-ci-robot · 2024-08-01T14:51:45Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-37288 has been cloned as Jira Issue OCPBUGS-37823. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-37823: GCP passthrough permissions check to ignore problematic permissions.

In response to this:

This is an automated cherry-pick of #730

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-08-01T14:52:22Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-37823, which is invalid:

expected dependent Jira Issue OCPBUGS-37288 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #730

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

codecov · 2024-08-01T15:15:02Z

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.34%. Comparing base (e12d56a) to head (9bb5819).
Report is 2 commits behind head on release-4.14.

Files	Patch %	Lines
pkg/operator/utils/gcp/utils.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.14     #741      +/-   ##
================================================
- Coverage         48.35%   48.34%   -0.02%     
================================================
  Files                96       96              
  Lines             11758    11762       +4     
================================================
  Hits               5686     5686              
- Misses             5439     5443       +4     
  Partials            633      633

Files	Coverage Δ
pkg/operator/utils/gcp/utils.go	`69.89% <0.00%> (-3.15%)`	⬇️

jstuever · 2024-08-12T18:15:50Z

/assign

jstuever · 2024-08-12T18:15:58Z

/jira refresh

openshift-ci-robot · 2024-08-12T18:16:05Z

@jstuever: This pull request references Jira Issue OCPBUGS-37823, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-37288 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-37288 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
bug has dependents

Requesting review from QA contact:
/cc @jianping-shu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jstuever · 2024-08-12T18:16:32Z

/lgtm
/approve

jstuever · 2024-08-12T18:16:47Z

/label backport-risk-assessed

openshift-ci · 2024-08-12T18:16:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jstuever · 2024-08-12T18:20:38Z

/test security

jstuever · 2024-08-12T18:45:33Z

/override ci/prow/security
There is another jira bug to handle this issue.

openshift-ci · 2024-08-12T18:47:11Z

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to this:

/override ci/prow/security
There is another jira bug to handle this issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jianping-shu · 2024-08-13T07:27:02Z

Verified with cluster-bot build 4.14.0-0.ci.test-2024-08-13-032243-ci-ln-rcb1c0t-latest.
The GCP cluster with Passthrough mode installed successfully and healthy.
The GCP cluster with default mode (i.e. Mint) installed successfully and healthy.
/label cherry-pick-approved

openshift-ci-robot · 2024-08-13T10:31:52Z

/retest-required

Remaining retests: 0 against base HEAD bd31680 and 2 for PR HEAD 9bb5819 in total

openshift-ci · 2024-08-13T12:56:13Z

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`9bb5819`	link	false	`/test security`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-08-13T13:03:25Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-37823: All pull requests linked via external trackers have merged:

openshift/cloud-credential-operator#741

Jira Issue OCPBUGS-37823 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #730

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-08-15T01:56:12Z

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator
This PR has been included in build ose-cloud-credential-operator-container-v4.14.0-202408150010.p0.gcb6aa58.assembly.stream.el8.
All builds following this will include this PR.

openshift-cherrypick-robot self-assigned this Aug 1, 2024

openshift-cherrypick-robot mentioned this pull request Aug 1, 2024

[release-4.15] OCPBUGS-37288: GCP passthrough permissions check to ignore problematic permissions. #730

Merged

openshift-ci bot changed the title ~~[release-4.14] OCPBUGS-37288: GCP passthrough permissions check to ignore problematic permissions.~~ [release-4.14] OCPBUGS-37823: GCP passthrough permissions check to ignore problematic permissions. Aug 1, 2024

openshift-ci bot requested review from dlom and lleshchi August 1, 2024 14:54

openshift-ci bot assigned jstuever Aug 12, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 12, 2024

openshift-ci bot requested a review from jianping-shu August 12, 2024 18:16

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 12, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2024

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 13, 2024

openshift-merge-bot bot merged commit cb6aa58 into openshift:release-4.14 Aug 13, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-4.14] OCPBUGS-37823: GCP passthrough permissions check to ignore problematic permissions. #741

[release-4.14] OCPBUGS-37823: GCP passthrough permissions check to ignore problematic permissions. #741

openshift-cherrypick-robot commented Aug 1, 2024

openshift-ci-robot commented Aug 1, 2024

openshift-ci-robot commented Aug 1, 2024

codecov bot commented Aug 1, 2024 •

edited

Loading

jstuever commented Aug 12, 2024

jstuever commented Aug 12, 2024

openshift-ci-robot commented Aug 12, 2024

jstuever commented Aug 12, 2024

jstuever commented Aug 12, 2024

openshift-ci bot commented Aug 12, 2024

jstuever commented Aug 12, 2024

jstuever commented Aug 12, 2024

openshift-ci bot commented Aug 12, 2024

jianping-shu commented Aug 13, 2024

openshift-ci-robot commented Aug 13, 2024

openshift-ci bot commented Aug 13, 2024

openshift-ci-robot commented Aug 13, 2024

openshift-bot commented Aug 15, 2024

[release-4.14] OCPBUGS-37823: GCP passthrough permissions check to ignore problematic permissions. #741

[release-4.14] OCPBUGS-37823: GCP passthrough permissions check to ignore problematic permissions. #741

Conversation

openshift-cherrypick-robot commented Aug 1, 2024

openshift-ci-robot commented Aug 1, 2024

openshift-ci-robot commented Aug 1, 2024

codecov bot commented Aug 1, 2024 • edited Loading

Codecov Report

jstuever commented Aug 12, 2024

jstuever commented Aug 12, 2024

openshift-ci-robot commented Aug 12, 2024

jstuever commented Aug 12, 2024

jstuever commented Aug 12, 2024

openshift-ci bot commented Aug 12, 2024

jstuever commented Aug 12, 2024

jstuever commented Aug 12, 2024

openshift-ci bot commented Aug 12, 2024

jianping-shu commented Aug 13, 2024

openshift-ci-robot commented Aug 13, 2024

openshift-ci bot commented Aug 13, 2024

openshift-ci-robot commented Aug 13, 2024

openshift-bot commented Aug 15, 2024

codecov bot commented Aug 1, 2024 •

edited

Loading