[OCPCLOUD-1860] Merge https://github.com/kubernetes/cloud-provider-aws:master into master #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cloud-team-rebase-bot[bot]](https://avatars.githubusercontent.com/u/74064623?s=60&v=4){kind=small}
This cleans up some of the documentation for the `ecr-credential-provider` command to expand on some details and fix some minor formatting in the example configuration. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Time.Unix() returns the time in seconds so need to multiply the duration by time.Second
Bump K8s libs to 0.25.3
Release version v1.25.1
Calculate cache duration correctly
Updates the v1 provider's isRegionValid function to return an error instead of boolean. This fixes the bug, where errors returned from EC2 instance metadata service client were suppressed and interpreted upstream as an invalid configured region. The isRegionValid function was renamed to validateRegion to also communicate its behavior instead of a boolean check.
Run e2e tests with `--dns=none`
Bump aws-sdk-go version to 1.44.145
Bump k8s deps to 1.26.0-rc.1
Update Go to v1.19.3
Release 1.26.0-rc.1
Migrate k8s e2e to Ginkgo 2.0
Release 1.26.0-alpha.1
Update README with latest releases
openshift-merge-robot
added
the
needs-rebase
# Conflicts: # .github/workflows/tag-release.yml
Service handling logic in k8s.io/cloud-provider v0.25.(0,1,2) is broken. This issue was fixed upstream, but not released yet. We are expecting that this fixes will be included into v0.25.3, but now need to replace released `cloud-provider` library version with the latest version from `release-1.25` branch. Xref: kubernetes/kubernetes#112793 This commit is expected to be dropped during next rebase.
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
7685f16
to
94c8b52
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
elmiko
changed the title
|
this rebase will contain the upstream 1.26 changes /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
1 similar comment
|
/retest-required |
|
@cloud-team-rebase-bot[bot]: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.