Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2460: Adds acr-credential-provider spec file and build script #105

Merged

Conversation

theobarberbany
Copy link

@theobarberbany theobarberbany commented Feb 1, 2024

  • Adds .spec file to build the acr-credential-provider
  • Updates openshift.mk to allow builds of acr-credential-provider
  • Adds build-rpms.sh to build RPMs in CI
  • Updates build-go.sh to allow override of REPO_ROOT

@theobarberbany theobarberbany changed the title Adds acr-credential-provider spec file OCPCLOUD-2460: Adds acr-credential-provider spec file Feb 1, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 1, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 1, 2024

@theobarberbany: This pull request references OCPCLOUD-2460 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

  • Adds .spec file to build the acr-credential-provider
  • Updates openshift.mk to allow builds of acr-credential-provider

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 1, 2024

@theobarberbany: This pull request references OCPCLOUD-2460 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany
Copy link
Author

/retest-required

acr-credential-provider.spec Outdated Show resolved Hide resolved
acr-credential-provider.spec Outdated Show resolved Hide resolved
@theobarberbany theobarberbany force-pushed the tb/acr-cred-provider-spec branch 2 times, most recently from dd697ad to 83020ec Compare February 2, 2024 16:32
@JoelSpeed
Copy link

Do we have a way to prove this works prior to merging?

@theobarberbany
Copy link
Author

@JoelSpeed Yep, when we ask ART to get production builds running they can target this branch. It's slightly more back and forth but far more representative than my local machine!

@theobarberbany
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2024
@theobarberbany theobarberbany changed the title OCPCLOUD-2460: Adds acr-credential-provider spec file OCPCLOUD-2460: Adds acr-credential-provider spec file and build script Feb 8, 2024
@theobarberbany theobarberbany force-pushed the tb/acr-cred-provider-spec branch 3 times, most recently from 266a367 to bbd56b9 Compare February 8, 2024 11:29
@JoelSpeed
Copy link

Pending proof in CI, LGTM

@theobarberbany theobarberbany force-pushed the tb/acr-cred-provider-spec branch 4 times, most recently from ac18dfa to c6d6a5a Compare February 12, 2024 17:55
…cript

- Adds .spec file to build the acr-credential-provider
- Updates openshift.mk to allow builds of acr-credential-provider
- Adds build-rpms.sh to build RPMs in CI
- Updates build-go.sh to allow override of REPO_ROOT
@theobarberbany theobarberbany force-pushed the tb/acr-cred-provider-spec branch 2 times, most recently from feabe42 to b4c1059 Compare February 13, 2024 09:51
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2024

@theobarberbany: This pull request references OCPCLOUD-2460 which is a valid jira issue.

In response to this:

  • Adds .spec file to build the acr-credential-provider
  • Updates openshift.mk to allow builds of acr-credential-provider
  • Adds build-rpms.sh to build RPMs in CI
  • Updates build-go.sh to allow override of REPO_ROOT

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany
Copy link
Author

CI Builds working: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/48588/rehearse-48588-pull-ci-openshift-cloud-provider-azure-master-images/1757324569267408896

[root@3a15a08b92af ~]# yum install acr-credential-provider-4.16.0-20240213T090247Z.el9.x86_64.rpm
Last metadata expiration check: 0:04:25 ago on Tue Feb 13 09:16:17 2024.
Dependencies resolved.
==============================================================================================
 Package                    Arch      Version                           Repository       Size
==============================================================================================
Installing:
 acr-credential-provider    x86_64    4.16.0-20240213T090247Z.el9       @commandline     10 M

Transaction Summary
==============================================================================================
Install  1 Package

Total size: 10 M
Installed size: 25 M
Is this ok [y/N]: y
Downloading Packages:
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                      1/1
  Running scriptlet: acr-credential-provider-4.16.0-20240213T090247Z.el9.x86_64           1/1
  Installing       : acr-credential-provider-4.16.0-20240213T090247Z.el9.x86_64           1/1
  Running scriptlet: acr-credential-provider-4.16.0-20240213T090247Z.el9.x86_64           1/1
  Verifying        : acr-credential-provider-4.16.0-20240213T090247Z.el9.x86_64           1/1

Installed:
  acr-credential-provider-4.16.0-20240213T090247Z.el9.x86_64

Complete!
[root@3a15a08b92af ~]# cd /usr/libexec/kubelet-image-credential-provider-plugins/
[root@3a15a08b92af kubelet-image-credential-provider-plugins]# ls
acr-credential-provider
[root@3a15a08b92af kubelet-image-credential-provider-plugins]# ./acr-credential-provider
Error: requires at least 1 arg(s), only received 0
Usage:
  acr-credential-provider configFile [flags]

Flags:
  -h, --help   help for acr-credential-provider

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2024
@JoelSpeed
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
Copy link

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
Copy link

openshift-ci bot commented Feb 13, 2024

@theobarberbany: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ed46763 into openshift:master Feb 13, 2024
10 checks passed
@theobarberbany theobarberbany deleted the tb/acr-cred-provider-spec branch February 13, 2024 12:54
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-cloud-controller-manager-container-v4.16.0-202402131411.p0.ged46763.assembly.stream.el9 for distgit ose-azure-cloud-controller-manager.
All builds following this will include this PR.

@theobarberbany
Copy link
Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@theobarberbany: new pull request created: #114

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants