New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPCLOUD-2460: Adds acr-credential-provider spec file and build script #105
OCPCLOUD-2460: Adds acr-credential-provider spec file and build script #105
Conversation
theobarberbany
commented
Feb 1, 2024
•
edited
edited
- Adds .spec file to build the acr-credential-provider
- Updates openshift.mk to allow builds of acr-credential-provider
- Adds build-rpms.sh to build RPMs in CI
- Updates build-go.sh to allow override of REPO_ROOT
@theobarberbany: This pull request references OCPCLOUD-2460 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
e198299
to
07508ef
Compare
/jira refresh |
@theobarberbany: This pull request references OCPCLOUD-2460 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
dd697ad
to
83020ec
Compare
Do we have a way to prove this works prior to merging? |
@JoelSpeed Yep, when we ask ART to get production builds running they can target this branch. It's slightly more back and forth but far more representative than my local machine! |
/hold |
266a367
to
bbd56b9
Compare
Pending proof in CI, LGTM |
ac18dfa
to
c6d6a5a
Compare
…cript - Adds .spec file to build the acr-credential-provider - Updates openshift.mk to allow builds of acr-credential-provider - Adds build-rpms.sh to build RPMs in CI - Updates build-go.sh to allow override of REPO_ROOT
feabe42
to
b4c1059
Compare
@theobarberbany: This pull request references OCPCLOUD-2460 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[root@3a15a08b92af ~]# yum install acr-credential-provider-4.16.0-20240213T090247Z.el9.x86_64.rpm
Last metadata expiration check: 0:04:25 ago on Tue Feb 13 09:16:17 2024.
Dependencies resolved.
==============================================================================================
Package Arch Version Repository Size
==============================================================================================
Installing:
acr-credential-provider x86_64 4.16.0-20240213T090247Z.el9 @commandline 10 M
Transaction Summary
==============================================================================================
Install 1 Package
Total size: 10 M
Installed size: 25 M
Is this ok [y/N]: y
Downloading Packages:
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
Preparing : 1/1
Running scriptlet: acr-credential-provider-4.16.0-20240213T090247Z.el9.x86_64 1/1
Installing : acr-credential-provider-4.16.0-20240213T090247Z.el9.x86_64 1/1
Running scriptlet: acr-credential-provider-4.16.0-20240213T090247Z.el9.x86_64 1/1
Verifying : acr-credential-provider-4.16.0-20240213T090247Z.el9.x86_64 1/1
Installed:
acr-credential-provider-4.16.0-20240213T090247Z.el9.x86_64
Complete! [root@3a15a08b92af ~]# cd /usr/libexec/kubelet-image-credential-provider-plugins/
[root@3a15a08b92af kubelet-image-credential-provider-plugins]# ls
acr-credential-provider
[root@3a15a08b92af kubelet-image-credential-provider-plugins]# ./acr-credential-provider
Error: requires at least 1 arg(s), only received 0
Usage:
acr-credential-provider configFile [flags]
Flags:
-h, --help help for acr-credential-provider /unhold |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@theobarberbany: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-azure-cloud-controller-manager-container-v4.16.0-202402131411.p0.ged46763.assembly.stream.el9 for distgit ose-azure-cloud-controller-manager. |
/cherry-pick release-4.15 |
@theobarberbany: new pull request created: #114 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |