OCPBUGS-28244: Call azureStackOverrides when parsing environment from env vars

[theobarberbany]

This change calls azureStackOverrides on the env if we build from
environment.conf, rather than using the resourceManagerEndpoint.

We want to remove this once kubernetes-sigs#5558 is resolved.

[theobarberbany]

/hold

I'm not sure if this impacts azure or only stackhub. Let's hold off until I do

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nrb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@theobarberbany: This pull request references Jira Issue OCPBUGS-28244, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This change calls azureStackOverrides on the env if we build from environment.conf, rather than using the resourceManagerEndpoint.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[theobarberbany]

/retest

[theobarberbany]

/jira refresh

[openshift-ci-robot]

@theobarberbany: This pull request references Jira Issue OCPBUGS-28244, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@theobarberbany: This pull request references Jira Issue OCPBUGS-28244, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

This change calls azureStackOverrides on the env if we build from
environment.conf, rather than using the resourceManagerEndpoint.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[theobarberbany]

These changes have been used to build cluster on azure gov, azure public and ash, all installs succeed.

OCP does not currently support Azure China Cloud: https://issues.redhat.com/browse/OCPSTRAT-320.

We're only changing the tests so they don't fail - but ultimately the functionaliy isnt needed so this is a no op.

/unhold

[theobarberbany]

/test e2e-azure-ovn

[openshift-ci]

@theobarberbany: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-upgrade	750c126	link	true	/test e2e-azure-ovn-upgrade
ci/prow/e2e-azure-ovn	750c126	link	true	/test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[theobarberbany]

Closing in favour of #112

[openshift-ci-robot]

@theobarberbany: This pull request references Jira Issue OCPBUGS-28244. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

This change calls azureStackOverrides on the env if we build from
environment.conf, rather than using the resourceManagerEndpoint.

We want to remove this once kubernetes-sigs#5558 is resolved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.