-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCP CI preparations #2
Conversation
openshift-hack/images/cloud-controller-manager-openshift.Dockerfile
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me, i do wonder about creating another top level directory (openshift-hack
). maybe we should just create hack/openshift
to keep things a little cleaner at the top level.
wdyt?
edit: unless we are using openshift-hack in other repos also
@elmiko, https://github.com/openshift/kubernetes - we using such format here. Initially I thought about |
LGTM |
…ecific makefile extension, openshift specific hack scripts
Added so far
Should be merged before openshift/release#18569