Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCP CI preparations #2

Merged
merged 1 commit into from
May 17, 2021
Merged

OCP CI preparations #2

merged 1 commit into from
May 17, 2021

Conversation

lobziik
Copy link

@lobziik lobziik commented May 13, 2021

Added so far

  • ocp specific dockerfiles
  • makefile with ocp specific targets
  • openshift-hack directory for storing hack scripts and dockerfiles

Should be merged before openshift/release#18569

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2021
@lobziik lobziik changed the title [WIP] OCP CI preparations OCP CI preparations May 14, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2021
@lobziik
Copy link
Author

lobziik commented May 14, 2021

@JoelSpeed @Danil-Grigorev @elmiko PTAL

Copy link

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, i do wonder about creating another top level directory (openshift-hack). maybe we should just create hack/openshift to keep things a little cleaner at the top level.

wdyt?

edit: unless we are using openshift-hack in other repos also

@lobziik
Copy link
Author

lobziik commented May 15, 2021

@elmiko, https://github.com/openshift/kubernetes - we using such format here. Initially I thought about hack/openshift, but then discovered how it's done in our kubernetes fork and did the same :)

@JoelSpeed
Copy link

LGTM

…ecific makefile extension, openshift specific hack scripts
@Danil-Grigorev Danil-Grigorev merged commit 70d0000 into openshift:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants