Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "UPSTREAM: 313: Bug 2065011: Reuse instance-groups for internal load balancers" #16

Merged

Conversation

Fedosin
Copy link

@Fedosin Fedosin commented Apr 19, 2022

Reverts #15

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 19, 2022

@Fedosin: This pull request references Bugzilla bug 2065011, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @miyadav

In response to this:

Revert "UPSTREAM: 313: Bug 2065011: Reuse instance-groups for internal load balancers"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link
Author

Fedosin commented Apr 20, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2022

@Fedosin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ccm-install c40a6a7 link false /test e2e-gcp-ccm-install
ci/prow/e2e-gcp-ccm c40a6a7 link false /test e2e-gcp-ccm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lobziik
Copy link

lobziik commented Apr 21, 2022

/approve
/lgtm

Such fails seems not connected with this changes

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lobziik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2022
@openshift-merge-robot openshift-merge-robot merged commit 4658f07 into openshift:master Apr 21, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 21, 2022

@Fedosin: All pull requests linked via external trackers have merged:

Bugzilla bug 2065011 has been moved to the MODIFIED state.

In response to this:

Revert "UPSTREAM: 313: Bug 2065011: Reuse instance-groups for internal load balancers"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nrb
Copy link

nrb commented Apr 17, 2023

@lobziik or @Fedosin Do either of you remember why this reverted by any chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants