OCPBUGS-6406: Merge https://github.com/kubernetes/cloud-provider-gcp:master into master #18
Conversation
![cloud-team-rebase-bot[bot]](https://avatars.githubusercontent.com/u/74064623?s=60&v=4){kind=small}
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
676418a
to
e063f73
Compare
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @cloud-team-rebase-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
2 times, most recently
from
984e9c5
to
d09f8bc
Compare
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
d09f8bc
to
61da7bc
Compare
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
2 times, most recently
from
ea3e90a
to
12092a5
Compare
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
12092a5
to
176df91
Compare
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
@Fedosin looking at the image job failure, did we have an issue with the vendor rebase? |
Create csr approver for kubelet readonly, it will loop all validators and approve only if all validator vote yes: 1. add three validators 2. create the approver 3. add feature gate option 4. unit test for each validator 5. main workflow how to handle csr Tested: Unit test local test
Update some message.
Update message
Read only resource csr approver
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
176df91
to
079749e
Compare
This was copied over and isn't correct. This is the new location for this plugin.
These CRDs will be used by the nodeipam controller for clusters that support multiple networks
remove deprecation warning in new clientauthplugin package
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
079749e
to
794dd3f
Compare
1. fix incorrect case 2. move got before expect 3. removed unnecessary bool 4. removed unnecessary break 5. Update the if/else block to be switch 6. modify the message in error 7. Fix validator error message in readonly approver. 8. validation error is in response.err, not in err. Tested: Unit test local test
Fix error message in readonly approver
Add network CRDs to cloud-provider-gcp
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
794dd3f
to
f0060dd
Compare
openshift-ci
bot
added
the
do-not-merge/hold
|
@lobziik: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test openshift-e2e-gcp-ovn-techpreview-upgrade |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lobziik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-gcp-ovn-ccm |
i'll take a look at squashing the OWNERS file commits |
|
/retitle OCPBUGS-6406: Merge https://github.com/kubernetes/cloud-provider-gcp:master into master |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@cloud-team-rebase-bot[bot]: This pull request references Jira Issue OCPBUGS-6406, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
…ed by Ingress-GCE (cherry picked from commit 97e991b)
This commit does multiple things: * changes owners of the project to people from OpenShift * removes upstream OWNERS files
elmiko
force-pushed
the
rebase-bot-master
branch
from
1933ab9
to
2e0341e
Compare
|
i've squashed the owners file commits into a single commit /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
@cloud-team-rebase-bot[bot]: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-6406 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@cloud-team-rebase-bot[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.