OCPBUGS-24044: Merge https://github.com/kubernetes/cloud-provider-gcp:master (522e293) into master #40
Conversation
![cloud-team-rebase-bot[bot]](https://avatars.githubusercontent.com/u/74064623?s=60&v=4){kind=small}
Bump go mods to use Kubernetes 1.28.2 libraries
Re-synced vendor.
Update golang.org/x/net to v0.17.0 to address CVE.
Add annotation to disable source mac validation per pod base
…emoved" This reverts commit a5df7a3.
Rollback PR#598 "Fix ILB deletion by checking for finalizer"
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @cloud-team-rebase-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
1b583a7
to
da89d8a
Compare
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
da89d8a
to
6a04d00
Compare
- After this commit repo will be unbuildable because of breaking changes in k8s-cloud-provider. Next commit will fix the build
- k8s-cloud-provider added "options ...cloud.Option" to every mock hook function signatures. This commit changes our mocks to have the same signature - This commit fixes repo build
Update k8s-cloud-provider version
Add constants to Network CRD
cloud-team-rebase-bot
bot
changed the title
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
2 times, most recently
from
9eb6555
to
83e5c61
Compare
…ed by Ingress-GCE (cherry picked from commit 97e991b)
Based on docs for internal loadbalancer here [1], backend services [2] and instances in instance-groups [3], following restrictions apply: - Internal LB can load balance to VMs in same region, but different subnets - Instance groups for the backend service must contain instance of the same subnet - An instance can only belong to one load balanced instance group - It is probably useful use-case to have nodes for the cluster belong to more than one subnet. And the current setup fails to create an internal load balancer with nodes in multiple subnets. This change finds pre-existing instance-groups that ONLY contain instances that belong to the cluster, uses them for the backend service. And only ensures instance-groups for remaining ones. [1] https://cloud.google.com/load-balancing/docs/internal [2] https://cloud.google.com/load-balancing/docs/backend-service#restrictions_and_guidance [3] https://cloud.google.com/compute/docs/instance-groups/creating-groups-of-unmanaged-instances#addinstances Co-authored-by: Abhinav Dahiya <abhinav.dahiya@redhat.com> Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com> # Conflicts: # vendor/k8s.io/cloud-provider-gcp/providers/gce/gce.go # vendor/k8s.io/cloud-provider-gcp/providers/gce/gce_fake.go # vendor/k8s.io/cloud-provider-gcp/providers/gce/gce_instancegroup.go # vendor/k8s.io/cloud-provider-gcp/providers/gce/gce_loadbalancer_internal.go
…r image to be consistent with ART Reconciling with https://github.com/openshift/ocp-build-data/tree/9dc2a375bf335e7e4e3d7e75abc5c3bdbb0c0e98/images/ose-gcp-cloud-controller-manager.yml
…r image to be consistent with ART Reconciling with https://github.com/openshift/ocp-build-data/tree/e5df10e41b14c724468c8f78e2690f219279bfc4/images/ose-gcp-cloud-controller-manager.yml
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
83e5c61
to
48f4c08
Compare
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
JoelSpeed
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@cloud-team-rebase-bot[bot]: This pull request references Jira Issue OCPBUGS-24044, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve Just manually tested this and it resolves an issue we have been having with internal to external migration /cherry-pick release-4.15 |
|
@JoelSpeed: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 6ad9e62
into
openshift:master
|
@cloud-team-rebase-bot[bot]: Jira Issue OCPBUGS-24044: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-24044 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-gcp-cloud-controller-manager-container-v4.16.0-202312181310.p0.g6ad9e62.assembly.stream for distgit ose-gcp-cloud-controller-manager. |
No description provided.