Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.24 into master #34

Merged
merged 33 commits into from
Apr 29, 2022
Merged

Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.24 into master #34

merged 33 commits into from
Apr 29, 2022

Conversation

cloud-team-rebase-bot[bot]
Copy link

No description provided.

@iksrochpub
Automated repo sync 20220312
d4ebca8 
Update module github.com/spf13/cobra to v1.4.0 (#2450)
@openshift-ci openshift-ci bot requested review from Fedosin and lobziik March 14, 2022 13:38
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 14, 2022

Hi @cloud-team-rebase-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iksrochpub
Automated repo sync 20220317
7c1c4aa 
Update module k8s.io/klog/v2 to v2.50.1 (#2538)
Update module github.com/stretchr/testify to v1.7.1 (#2537)
@iksrochpub
Automated repo sync 20220318
7348759 
Update module k8s.io/klog/v2 to v2.60.0 (#2557)
Update community (#2551)
@iksrochpub
Automated repo sync 20220322
4214064 
Update module k8s.io/klog/v2 to v2.60.1 (#2565)
@iksrochpub
Automated repo sync 20220324
6c1c70c 
Update from v1.24.0-alpha.3 to v1.24.0-alpha.4 (#2567)
Open dependency check issues to network squad (#2570)
@iksrochpub
Automated repo sync 20220325
f9c7747 
Doc URL update (#2539)
Update community (release-1.24) (patch) (#2569)
@iksrochpub
Automated repo sync 20220326
56c1b06 
Require BOM PRs for IBM CCM image updates (#2571)
@iksrochpub
Automated repo sync 20220329
55e0d81 
Branch release-1.24 CCM image updated (#2583)
@iksrochpub
Automated repo sync 20220330
a38a194 
Disable LB monitor if LB Class is defined in clusters: (#2566)
@iksrochpub
Automated repo sync 20220331
2da4c69 
Update module github.com/IBM/vpc-go-sdk to v0.18.0 (#2599)
@iksrochpub
Automated repo sync 20220401
36bfb24 
Update community to v0.24.0-beta.0 (#2616)
Add networking squad as code owners (release 1.24) (#2519)
Auto-create armada-ansible BOM PR (release 1.24) (#2582)
@iksrochpub
Automated repo sync 20220402
62ee752 
Update kube-update.sh to use hub-install make target (release 1.24) (#2617)
@iksrochpub
Automated repo sync 20220404
7dda13c 
Update from v1.24.0-alpha.4 to v1.24.0-beta.0 (#2636)
@iksrochpub
Automated repo sync 20220405
e49e979 
Update vpcctl binary to 3003 (release-1.24) (#2624)
Spelled armada wrong in deploy.sh script (release 1.24) (#2630)
@iksrochpub
Automated repo sync 20220407
fed68fa 
Remove the vpcctl binary from CCM - 1.24 (#2460)
@jckasper
Copy link

jckasper commented Apr 7, 2022

/ok-to-test

@openshift-ci
Copy link

openshift-ci bot commented Apr 7, 2022

@jckasper: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iksrochpub
Automated repo sync 20220408
0ae625c 
Update module github.com/IBM/vpc-go-sdk to v0.19.0 (release-1.24) (#2638)
@elmiko
Copy link

elmiko commented Apr 11, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 11, 2022
@elmiko
Copy link

elmiko commented Apr 27, 2022

@jckasper looks like the tests are still failing on a package in the vendor, does this look like a golang version issue to you?

also, i think we are using 1.18.1 in that build container, is it possible we have a minor version difference?

@jckasper
Copy link

@elmiko I don't think the issue is with the golang version anymore. My guess is that there is a still something messed up with the vendor subdir. Perhaps need to do a: go mod tidy to remove packages that are no longer needed and then a go mod vendor to make sure vendor subdir is updated with the latest that is needed.

iksrochpub and others added 12 commits April 28, 2022 02:00
@iksrochpub
Automated repo sync 20220428
43abc1b 
Update community to v0.24.0-rc.1 (#2666)
Update from v1.24.0-rc.0 to v1.24.0-rc.1 (#2665)
Update module github.com/IBM/platform-services-go-sdk to v0.24.1 (#2663)
@Fedosin
UPSTREAM: <carry>: Add OWNERS
e5bbb77
@Fedosin
UPSTREAM: <carry>: Add vendor/
09e505e
@Fedosin
UPSTREAM: <carry>: Add cloud-provider-vpc-controller git submodule
3b7642a 
It's taken from https://github.com/openshift/cloud-provider-vpc-controller
@Fedosin
UPSTREAM: <carry>: Add a Dockerfile that compatible with OpenShift
0dead15
UPSTREAM: <carry>: Updating and vendoring go modules after an upstrea…
788a13f 
…m rebase
UPSTREAM: <carry>: Updating and vendoring go modules after an upstrea…
43c31a2 
…m rebase
UPSTREAM: <carry>: bump cloud-provider-vpc-controller submodule
804d79f
UPSTREAM: <carry>: Updating ose-ibm-cloud-controller-manager images t…
d531b60 
…o be consistent with ART

Reconciling with https://github.com/openshift/ocp-build-data/tree/0059e470a61eba28225165168b22d9e77c33c926/images/ose-ibm-cloud-controller-manager.yml
UPSTREAM: <carry>: Updating and vendoring go modules after an upstrea…
b0ae7cf 
…m rebase
UPSTREAM: <carry>: Updating and vendoring go modules after an upstrea…
0fd9488 
…m rebase
UPSTREAM: <carry>: Merge branch 'master' in rebase
9cdf43b
@elmiko
Copy link

elmiko commented Apr 28, 2022

thanks @jckasper , i'll take a look at manually updating this patch.

@jckasper
Copy link

jckasper commented Apr 28, 2022 •
edited
Loading

@elmiko I took a look a quick look this branch and ran go mod tidy and go mod vendor.
End result: 91 files in the vendor/* directory are no longer needed and should be removed.
My guess is that some of these 91 files is causing the test errors.

I don't think I have auth to push these 91 vendor deletions to this branch/PR.

@elmiko
Copy link

elmiko commented Apr 28, 2022

thanks @jckasper ! i had not gotten back to testing it out yet. i'm guessing you don't have permission to push either, i can try to push later or you could open another PR and we could close this one.

@elmiko
Copy link

elmiko commented Apr 28, 2022

seems like i did have permissions to push on that branch. let's see how the tests go...

@elmiko
Copy link

elmiko commented Apr 28, 2022

looking a lot better

@openshift-ci
Copy link

openshift-ci bot commented Apr 28, 2022

@cloud-team-rebase-bot[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Fedosin
Fedosin approved these changes Apr 29, 2022
View reviewed changes
Copy link

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6b13dc4 into openshift:master Apr 29, 2022
@elmiko elmiko deleted the rebase-bot-master branch April 29, 2022 17:13
@elmiko elmiko restored the rebase-bot-master branch April 29, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

@Fedosin Fedosin Fedosin approved these changes

@lobziik lobziik Awaiting requested review from lobziik

Assignees

@Fedosin Fedosin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jckasper @elmiko @Karthik-K-N @Fedosin @openshift-merge-robot @iksrochpub