Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge https://github.com/kubernetes/cloud-provider-openstack:master into master #183

Closed

Conversation

shiftstack-merge-bot[bot]
Copy link

No description provided.

zetaab and others added 12 commits February 16, 2023 18:37
* fix testgate

* update golint, remove deprecated BuildNameToCertificate method

* remove cryptography override

* update secretstorage
…s#2076)

Signed-off-by: Hugo Larcher <hugo.larcher@ovhcloud.com>
Signed-off-by: Ondrej Vasko <o.vasko@pan-net.eu>
Adding annotations to all manifest came to as a requirement of
wanting to set  specific annotations to force this
component to be installed with priority over other application
subcharts that might be deployed at the same time.
* use ubuntu focal

* update k3s used in tests

* update default version
@openshift-ci
Copy link

openshift-ci bot commented Feb 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shiftstack-merge-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign pierreprinetti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 20, 2023

Hi @shiftstack-merge-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 20, 2023
@pierreprinetti
Copy link
Member

/retest-required

@dulek
Copy link

dulek commented Feb 20, 2023

Looks like some real issue:
2023-02-20T13:09:32.408350319Z E0220 13:09:32.407476 1 utils.go:95] [ID:336] GRPC error: rpc error: code = Internal desc = DeleteVolume failed with error Bad request with: [DELETE https://38.102.83.188:13776/v3/fc706a2473b64d93bb1f13493d80e330/volumes/ae71f9cc-a308-42bb-a932-1fea52ef3295], error message: {"badRequest": {"code": 400, "message": "Invalid volume: Volume status must be available or error or error_restoring or error_extending or error_managing and must not be migrating, attached, belong to a group, have snapshots or be disassociated from snapshots after volume transfer."}}

@dulek
Copy link

dulek commented Feb 20, 2023

Hm, but this doesn't seem to touch Cinder CSI?
/retest

@pierreprinetti
Copy link
Member

/hold
Until kubernetes#2120 is resolved

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2023
pierreprinetti and others added 2 commits February 20, 2023 12:59
* [occm] Revert seeding of math/rand source

In Go v1.20, `rand.Seed` is deprecated and `math/rand`'s is
automatically seeded. However, that doesn't happen in Go v1.19 that is
used to build this branch.

With this commit, the global source for `math/rand` is seeded again in
`main.go`.

* go-lint: Upgrade staticcheck to v0.4.2

which handles deprecations more gracefully.
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
Co-authored-by: Jesse Haka <haka.jesse@gmail.com>
@mandre
Copy link
Member

mandre commented Feb 27, 2023

/test e2e-openstack-csi-cinder

@pierreprinetti
Copy link
Member

/hold cancel
bd05a95

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2023
* implement instances v2

* fix listopts to use regexp, remove dead code
@mandre
Copy link
Member

mandre commented Feb 28, 2023

/test e2e-openstack-csi-cinder

@mandre
Copy link
Member

mandre commented Feb 28, 2023

Same result. Either this is a legit failure, or the CI is broken. In any case, it's not worth retesting until we spend more time investigating.

@mandre
Copy link
Member

mandre commented Apr 5, 2023

/retest

@mandre
Copy link
Member

mandre commented Apr 5, 2023

This PR doesn't include all the latest changes from master since merge bot had conflicts:

Manual intervention is needed to merge https://github.com/kubernetes/cloud-provider-openstack:master into openshift/cloud-provider-openstack:master: Git merge failed: Cmd('git') failed due to: exit code(1)
  cmdline: git merge source/master --no-commit
  stdout: 'Removing cluster/images/openstack-cloud-controller-manager/Dockerfile.build
Removing cluster/images/openstack-cloud-controller-manager/Dockerfile
Removing cluster/images/octavia-ingress-controller/Dockerfile.build
Removing cluster/image

@MaysaMacedo
Copy link

/retest

@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2023

@shiftstack-merge-bot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-csi-cinder d76b468 link false /test e2e-openstack-csi-cinder

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre
Copy link
Member

mandre commented Apr 6, 2023

Closing in favor of #192.

@mandre
Copy link
Member

mandre commented Apr 6, 2023

/close

@openshift-ci openshift-ci bot closed this Apr 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2023

@mandre: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet