OCPBUGS-12772: Merge https://github.com/kubernetes/cloud-provider-openstack:master into master #192
Conversation
* fix testgate * update golint, remove deprecated BuildNameToCertificate method * remove cryptography override * update secretstorage
…s#2076) Signed-off-by: Hugo Larcher <hugo.larcher@ovhcloud.com>
Signed-off-by: Ondrej Vasko <o.vasko@pan-net.eu>
Adding annotations to all manifest came to as a requirement of wanting to set specific annotations to force this component to be installed with priority over other application subcharts that might be deployed at the same time.
* use ubuntu focal * update k3s used in tests * update default version
* [occm] Revert seeding of math/rand source In Go v1.20, `rand.Seed` is deprecated and `math/rand`'s is automatically seeded. However, that doesn't happen in Go v1.19 that is used to build this branch. With this commit, the global source for `math/rand` is seeded again in `main.go`. * go-lint: Upgrade staticcheck to v0.4.2 which handles deprecations more gracefully.
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com> Co-authored-by: Jesse Haka <haka.jesse@gmail.com>
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
* implement instances v2 * fix listopts to use regexp, remove dead code
* Don't get git version with VERSION is overridden It creates an ugly error in the CI logs when there's no git checkout. * Fix cloudbuild issues
…es#2124) (kubernetes#2126) * [occm] Do not send the subnet-id if it is empty for members during the creation of fully populated loadbalancer.
* use go 1.20 * remove rand seed
…tes#2155) We can't use the vanilla docker image because we also need the `gcloud` binary.
* occm: implement an optional atomic routes update * Fix IPv6 detection logic in routes
|
/hold cancel |
openshift-ci-robot
added
jira/valid-bug
|
@mandre: This pull request references Jira Issue OCPBUGS-12772, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Due to the mass of changes this sync PR is carrying, despite having an open bug we want to wait until master is again open for changes. |
openshift-ci
bot
added
the
do-not-merge/hold
Previously in e2e tests we only used ci-built occm for the occm e2e test. The cinder and manila e2e tests used the latest release occm image. With this change all e2e tests deploy a ci-built occm.
* fix(occm): daemonset annotations * feat(occm): update chart version
The `storage.googleapis.com/kubernetes-release` URL is a hard coded path to a GCS bucket location. To allow redirecting and spreading the load across multiple hosting locations, the `dl.k8s.io` URL has been introduced. Signed-off-by: Sean McGinnis <stmcg@amazon.com>
`ensureSecurityRule()` is used to add a rule to an existing security group. At first it was listing all the rules in the SG and then if the requested rule wasn't present it was adding it. This has some risk - the list of SG rules can be modified in-between by some other thread. This commit changes the logic of that function to just try to create the rule. Neutron API will return 409 Conflict if the rule already exists and if it does OCCM will just ignore the error and move on.
Seems like there was some dead code related to handling of the security groups in the implementation of the LoadBalancer Services support. This commit removes it. In particular: * `LoadBalancerOpts.NodeSecurityGroupIDs` is never populated, so we can remove it as well as code using it. * `IsAllowAll` function is never used. Moreover I have no idea why it was exported.
* Fix CSI spec versions * Bump csi-resizer to v1.8.0 * Fix docker image tag in manila e2e tests
|
@mandre: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
No reason to block this any further. If something breaks, this will be limited to OpenStack platform and we're keeping an eye on it anyway. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, mandre, pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mandre: Jira Issue OCPBUGS-12772: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-12772 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Supersedes #183 that wasn't automatically updated due to a conflict.