Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge https://github.com/kubernetes/cloud-provider-openstack:master into master #200

Merged
merged 10 commits into from Jul 6, 2023

Conversation

shiftstack-merge-bot[bot]
Copy link

No description provided.

simonostendorf and others added 7 commits May 31, 2023 00:51
* feat(occm): add secret enabled option

* fix(occm): helm template operator

* feat(occm): update chart version

* fix(occm): use newer chart version

* fix(occm): remove trailing spaces
…es#2250)

os-interfaces is a proxy API for neutron's ports list. This has 2
significant disadvantages to us:
* It adds the overhead of an extra API call every time it is used
* It doesn't contain all the information returned by Neutron
…ubernetes#2264)

* feat(cinder-csi): enable secret injection and common annotations

* fix(cinder-csi): default secret value hostMount

* fix(cinder-csi): pod annotations

* fix(cinder-csi): pod annotations

* fix(cinder-csi): values typo
the csi driver images are built with a prefix
"v0.0.".
…bernetes#2232)

* fixed the typo on loadbalancer config

fixed the typo on loadbalancer config

* bumped the openstack-cloud-controller-manager chart version
…e. (kubernetes#2278)

* Refactor and enhance Barbican KMS plugin codebase.

* fixed the formmating issue
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 29, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2023

Hi @shiftstack-merge-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Jun 30, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 3, 2023

@shiftstack-merge-bot[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

The only thing that affects us is kubernetes#2250 if I'm not mistaken.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, shiftstack-merge-bot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit 270e2df into openshift:master Jul 6, 2023
4 checks passed
@pierreprinetti pierreprinetti deleted the merge-bot-master branch July 6, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants