Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-15973: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13 #202

Merged
merged 18 commits into from Jul 19, 2023

Conversation

mandre
Copy link
Member

@mandre mandre commented Jul 7, 2023

No description provided.

zetaab and others added 18 commits January 9, 2023 08:16
* fix testgate

* update golint, remove deprecated BuildNameToCertificate method

* remove cryptography override

* update secretstorage

* downgrade e2e test version
…26 (kubernetes#2112)

* add annotation for real address

* add load-balancer-address annotation doc
…tes#2122)

* go-lint: Upgrade staticcheck to v0.4.2

which handles deprecations more gracefully.

* [occm] Revert seeding of math/rand source

In Go v1.20, `rand.Seed` is deprecated and `math/rand`'s is
automatically seeded. However, that doesn't happen in Go v1.19 that is
used to build this branch.

With this commit, the global source for `math/rand` is seeded again in
`main.go`.
Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
kubernetes#2134) (kubernetes#2152)

* occm: implement an optional atomic routes update

* Fix IPv6 detection logic in routes
* modify images to use registry.k8s.io

* fix image names
* update tags and vendor

* update docs tags
Conflicts:
      cluster/images/cinder-csi-plugin/Dockerfile
      cluster/images/cinder-csi-plugin/Dockerfile.build
      go.mod
@openshift-ci openshift-ci bot requested review from dulek and MaysaMacedo July 7, 2023 09:10
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@dulek
Copy link

dulek commented Jul 7, 2023

/lgtm

We'll need to find a bug to tie this to first, but in general this looks clean.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2023

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre
Copy link
Member Author

mandre commented Jul 10, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 10, 2023
@mandre mandre changed the title Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13 OCPBUGS-15973: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13 Jul 10, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2023
@openshift-ci-robot
Copy link

@mandre: This pull request references Jira Issue OCPBUGS-15973, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 10, 2023
@mandre
Copy link
Member Author

mandre commented Jul 10, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 10, 2023
@openshift-ci-robot
Copy link

@mandre: This pull request references Jira Issue OCPBUGS-15973, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-15974 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-15974 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eurijon
Copy link

eurijon commented Jul 19, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 19, 2023
@openshift-merge-robot openshift-merge-robot merged commit c59255a into openshift:release-4.13 Jul 19, 2023
7 checks passed
@openshift-ci-robot
Copy link

@mandre: Jira Issue OCPBUGS-15973: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15973 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet