Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-20124: FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.25 into release-4.12 #220

Merged
merged 4 commits into from Oct 12, 2023

Conversation

mandre
Copy link
Member

@mandre mandre commented Oct 5, 2023

Replaces #209

Conflicts:
      OWNERS

Co-authored-by: jichenjc <jichenjc@cn.ibm.com>
Co-authored-by: Matthew Booth <mbooth@redhat.com>
… memory allocation, add more logs (kubernetes#2308)

* avoid unnecessary memory allocation with more logs

* Fix pagination parsing

---------

Co-authored-by: kayrus <kay.diam@gmail.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2023
@dulek
Copy link

dulek commented Oct 5, 2023

/retest

@dulek
Copy link

dulek commented Oct 5, 2023

/retitle OCPBUGS-20124: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.25 into release-4.12

@openshift-ci openshift-ci bot changed the title Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.25 into release-4.12 OCPBUGS-20124: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.25 into release-4.12 Oct 5, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 5, 2023
@openshift-ci-robot
Copy link

@mandre: This pull request references Jira Issue OCPBUGS-20124, which is invalid:

  • expected Jira Issue OCPBUGS-20124 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Replaces #209

Conflicts:
     OWNERS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link

dulek commented Oct 5, 2023

/jira refresh

@openshift-ci-robot
Copy link

@dulek: This pull request references Jira Issue OCPBUGS-20124, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20133 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member Author

mandre commented Oct 6, 2023

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2023

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member Author

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 10, 2023
@itzikb-redhat
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 11, 2023
@rlobillo
Copy link

Pre-verified in custom OCP4.12 payload including this fix (thanks to cluster-bot) on top of RHOS-16.2-RHEL-8-20230510.n.1.

  1. Edit cinder.conf on the controllers:
sudo -i
mv /var/lib/config-data/puppet-generated/cinder/etc/cinder/cinder.conf /var/lib/config-data/puppet-generated/cinder/etc/cinder/cinder.conf_bk
sed 's/#osapi_max_limit =.*/osapi_max_limit = 9/' /var/lib/config-data/puppet-generated/cinder/etc/cinder/cinder.conf_bk > /var/lib/config-data/puppet-generated/cinder/etc/cinder/cinder.conf
podman ps -a |grep cinder_api$ | awk '{print $1}' | xargs podman restart
podman exec -it cinder_api grep osapi_max_limit /etc/cinder/cinder.conf 
osapi_max_limit = 9

  1. monitor csi-attacher logs:

$ oc logs -n openshift-cluster-csi-drivers -c csi-attacher -l app=openstack-cinder-csi-driver-controller -f

  1. Apply extra_pvc.yaml and wait for logs:
I1011 09:44:41.017089       1 csi_handler.go:251] Attaching "csi-604cfacec3b7a9f4ee19db7fb75503865918988ba4834c30ad28647582e484b4"
I1011 09:44:46.160694       1 csi_handler.go:264] Attached "csi-604cfacec3b7a9f4ee19db7fb75503865918988ba4834c30ad28647582e484b4"
I1011 09:44:49.987966       1 csi_handler.go:251] Attaching "csi-7aa553e1eb1dd8140b36b92d3bf022cccbd47bcea8c002233019fc5667de1e96"
I1011 09:44:54.258573       1 csi_handler.go:264] Attached "csi-7aa553e1eb1dd8140b36b92d3bf022cccbd47bcea8c002233019fc5667de1e96"
I1011 09:44:55.932280       1 csi_handler.go:251] Attaching "csi-21dbc49f6c15007c8299e06dceb65c62b4706e2dab254852bf37a50bb629d610"
I1011 09:44:59.449034       1 csi_handler.go:264] Attached "csi-21dbc49f6c15007c8299e06dceb65c62b4706e2dab254852bf37a50bb629d610"                                                                                                            
I1011 09:49:10.389687       1 csi_handler.go:251] Attaching "csi-56b5c4799be147d059cbce2bba61853a67e09711fafae6b889677f2c342015c9"                                                                                                           
I1011 09:49:10.391690       1 csi_handler.go:251] Attaching "csi-5680a8cfe38af997349eb1648609d82d726805efa9e75a75aabcc36dfdc07892"                                                                                                           
I1011 09:49:10.392602       1 csi_handler.go:251] Attaching "csi-6d95858639ceeed0d540188432e0f0ee086142acbaf602f83b24af9f0176d4dc"                                                                                                           
I1011 09:49:10.394018       1 csi_handler.go:251] Attaching "csi-118e97d558f1452650752fac568b16c3968c1f7114a948657b1c452201c49d74"                                                                                                           
I1011 09:49:10.394812       1 csi_handler.go:251] Attaching "csi-ca1a6d31b21928bc39f8b36a05cccab874b78ca4c2f6b9b4400f660e5d34e6e2"                                                                                                           
I1011 09:49:10.396311       1 csi_handler.go:251] Attaching "csi-25ee14c15e09e19023f6b19a674968a65a22ecfa856f69736bf876a7e3160219"                                                                                                           
I1011 09:49:10.396323       1 csi_handler.go:251] Attaching "csi-3b3886c6beac817ce18721e33d234817666fb2cb607656c1d19c52002a6b6973"                                                                                                           
I1011 09:49:10.396447       1 csi_handler.go:251] Attaching "csi-85d6b276f7d643b0268317a3acd88508d2250eaa3949674ca6b7cd653fb91b47"                                                                                                           
I1011 09:49:10.396734       1 csi_handler.go:251] Attaching "csi-6e596cc7fcc75c900470a22dc1fa65628e457ab68ad3d10df0e47215bbb033bf"                                                                                                           
I1011 09:49:10.404467       1 csi_handler.go:251] Attaching "csi-a2be6c1c7a82cc9d6d894f9494c31ef63eb897137d42eceeb0fce6f5643daecd"                                                                                                           
I1011 09:49:11.593053       1 request.go:601] Waited for 1.175257545s due to client-side throttling, not priority and fairness, request: PATCH:https://172.30.0.1:443/apis/storage.k8s.io/v1/volumeattachments/csi-a2be6c1c7a82cc9d6d894f9494c
31ef63eb897137d42eceeb0fce6f5643daecd
I1011 09:49:14.350760       1 csi_handler.go:264] Attached "csi-56b5c4799be147d059cbce2bba61853a67e09711fafae6b889677f2c342015c9"                                                                                                            
I1011 09:49:14.371742       1 csi_handler.go:251] Attaching "csi-88c13ec021bbd3b9cba720b3de843497731be4fdfab5451710a40cff1e900dce"                                                                                                           
I1011 09:49:16.038885       1 csi_handler.go:264] Attached "csi-118e97d558f1452650752fac568b16c3968c1f7114a948657b1c452201c49d74"                                                                                                            
I1011 09:49:17.685980       1 csi_handler.go:264] Attached "csi-6d95858639ceeed0d540188432e0f0ee086142acbaf602f83b24af9f0176d4dc"                                                                                                            
I1011 09:49:19.696518       1 csi_handler.go:264] Attached "csi-5680a8cfe38af997349eb1648609d82d726805efa9e75a75aabcc36dfdc07892"                                                                                                            
I1011 09:49:19.804973       1 csi_handler.go:264] Attached "csi-a2be6c1c7a82cc9d6d894f9494c31ef63eb897137d42eceeb0fce6f5643daecd"                                                                                                            
I1011 09:49:22.073909       1 csi_handler.go:264] Attached "csi-25ee14c15e09e19023f6b19a674968a65a22ecfa856f69736bf876a7e3160219"                                                                                                            
I1011 09:49:22.185865       1 csi_handler.go:264] Attached "csi-3b3886c6beac817ce18721e33d234817666fb2cb607656c1d19c52002a6b6973"                                                                                                            
I1011 09:49:22.193684       1 csi_handler.go:251] Attaching "csi-3b3886c6beac817ce18721e33d234817666fb2cb607656c1d19c52002a6b6973"                                                                                                           
I1011 09:49:22.756997       1 csi_handler.go:264] Attached "csi-3b3886c6beac817ce18721e33d234817666fb2cb607656c1d19c52002a6b6973"                                                                                                            
I1011 09:49:24.844247       1 csi_handler.go:264] Attached "csi-6e596cc7fcc75c900470a22dc1fa65628e457ab68ad3d10df0e47215bbb033bf"                                                                                                            
I1011 09:49:24.853774       1 csi_handler.go:251] Attaching "csi-6e596cc7fcc75c900470a22dc1fa65628e457ab68ad3d10df0e47215bbb033bf"                                                                                                           
I1011 09:49:24.954603       1 csi_handler.go:264] Attached "csi-85d6b276f7d643b0268317a3acd88508d2250eaa3949674ca6b7cd653fb91b47"                                                                                                            
I1011 09:49:25.500421       1 csi_handler.go:264] Attached "csi-6e596cc7fcc75c900470a22dc1fa65628e457ab68ad3d10df0e47215bbb033bf"                                                                                                            
I1011 09:49:27.287910       1 csi_handler.go:264] Attached "csi-ca1a6d31b21928bc39f8b36a05cccab874b78ca4c2f6b9b4400f660e5d34e6e2"                                                                                                            
I1011 09:49:28.849377       1 csi_handler.go:264] Attached "csi-88c13ec021bbd3b9cba720b3de843497731be4fdfab5451710a40cff1e900dce"      

The line:

.Adding back to VA queue for forced reprocessing.
is not observed on the csi-attacher container logs.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 11, 2023
@eurijon
Copy link

eurijon commented Oct 11, 2023

/jira refresh

@openshift-ci-robot
Copy link

@eurijon: This pull request references Jira Issue OCPBUGS-20124, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20133 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link

dulek commented Oct 11, 2023

/retitle OCPBUGS-20124, FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.25 into release-4.12

@openshift-ci openshift-ci bot changed the title OCPBUGS-20124: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.25 into release-4.12 OCPBUGS-20124, FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.25 into release-4.12 Oct 11, 2023
@openshift-ci-robot openshift-ci-robot removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 11, 2023
@openshift-ci-robot
Copy link

@mandre: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Replaces #209

Conflicts:
     OWNERS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link

dulek commented Oct 11, 2023

/retitle OCPBUGS-20124: FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.25 into release-4.12

@openshift-ci openshift-ci bot changed the title OCPBUGS-20124, FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.25 into release-4.12 OCPBUGS-20124: FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.25 into release-4.12 Oct 11, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 11, 2023
@openshift-ci-robot
Copy link

@mandre: This pull request references Jira Issue OCPBUGS-20124, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20133 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Replaces #209

Conflicts:
     OWNERS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link

dulek commented Oct 11, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eurijon
Copy link

eurijon commented Oct 11, 2023

/jira refresh

@openshift-ci-robot
Copy link

@eurijon: This pull request references Jira Issue OCPBUGS-20124, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20133 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link

dulek commented Oct 12, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 12, 2023
@openshift-ci-robot
Copy link

@dulek: This pull request references Jira Issue OCPBUGS-20124, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-20133 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-20133 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (rlobillo@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 9cb9cfe into openshift:release-4.12 Oct 12, 2023
5 checks passed
@openshift-ci-robot
Copy link

@mandre: Jira Issue OCPBUGS-20124: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20124 has been moved to the MODIFIED state.

In response to this:

Replaces #209

Conflicts:
     OWNERS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the sync-4.12 branch October 12, 2023 09:06
@openshift-merge-robot
Copy link

Fix included in accepted release 4.12.0-0.nightly-2023-10-12-160543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants