OCPBUGS-20133: FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13 #221

mandre · 2023-10-05T10:17:52Z

Replaces #208

Conflicts:
      OWNERS

Co-authored-by: jichenjc <jichenjc@cn.ibm.com>

… memory allocation, add more logs (kubernetes#2309) * avoid unnecessary memory allocation with more logs * Fix pagination parsing --------- Co-authored-by: kayrus <kay.diam@gmail.com>

Co-authored-by: Matthew Booth <mbooth@redhat.com>

Previously in e2e tests we only used ci-built occm for the occm e2e test. The cinder and manila e2e tests used the latest release occm image. With this change all e2e tests deploy a ci-built occm. Co-authored-by: Matthew Booth <mbooth@redhat.com>

…bernetes#2372) (kubernetes#2381)

Conflicts: OWNERS

dulek · 2023-10-05T11:09:56Z

/retitle OCPBUGS-20133: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13

openshift-ci-robot · 2023-10-05T11:10:17Z

@mandre: This pull request references Jira Issue OCPBUGS-20133, which is invalid:

expected Jira Issue OCPBUGS-20133 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Replaces #208
Conflicts:
     OWNERS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dulek · 2023-10-05T11:17:58Z

/jira refresh

openshift-ci-robot · 2023-10-05T11:18:01Z

@dulek: This pull request references Jira Issue OCPBUGS-20133, which is invalid:

expected dependent Jira Issue OCPBUGS-20132 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre · 2023-10-05T14:03:09Z

/retest

mandre · 2023-10-05T17:37:55Z

Hmm a few failures I have never seen. Seems like a flake to me but let's make sure:
/retest

openshift-ci · 2023-10-05T20:23:15Z

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mandre

/label backport-risk-assessed

gryf

/lgtm
/approve

openshift-ci · 2023-10-11T04:52:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gryf, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gryf,mandre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dulek · 2023-10-11T10:48:07Z

/retitle OCPBUGS-20133, FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13

openshift-ci-robot · 2023-10-11T10:48:53Z

@mandre: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Replaces #208
Conflicts:
     OWNERS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dulek · 2023-10-11T10:50:07Z

/retitle OCPBUGS-20133: FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13

openshift-ci-robot · 2023-10-11T10:50:33Z

@mandre: This pull request references Jira Issue OCPBUGS-20133, which is invalid:

expected dependent Jira Issue OCPBUGS-20132 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Replaces #208
Conflicts:
     OWNERS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rlobillo · 2023-10-11T15:10:53Z

/label cherry-pick-approved
/jira refresh

openshift-ci-robot · 2023-10-11T15:11:01Z

@rlobillo: This pull request references Jira Issue OCPBUGS-20133, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.z) matches configured target version for branch (4.13.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-20132 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-20132 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

In response to this:

/label cherry-pick-approved
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-11T15:19:52Z

@mandre: Jira Issue OCPBUGS-20133: All pull requests linked via external trackers have merged:

openshift/cloud-provider-openstack#221

Jira Issue OCPBUGS-20133 has been moved to the MODIFIED state.

In response to this:

Replaces #208
Conflicts:
     OWNERS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rlobillo · 2023-10-11T15:53:34Z

Pre-verified in custom OCP4.13 payload including this fix (thanks to cluster-bot) on top of RHOS-16.2-RHEL-8-20230510.n.1.

Edit cinder.conf on the controllers:

sudo -i
mv /var/lib/config-data/puppet-generated/cinder/etc/cinder/cinder.conf /var/lib/config-data/puppet-generated/cinder/etc/cinder/cinder.conf_bk
sed 's/#osapi_max_limit =.*/osapi_max_limit = 9/' /var/lib/config-data/puppet-generated/cinder/etc/cinder/cinder.conf_bk > /var/lib/config-data/puppet-generated/cinder/etc/cinder/cinder.conf
podman ps -a |grep cinder_api$ | awk '{print $1}' | xargs podman restart
podman exec -it cinder_api grep osapi_max_limit /etc/cinder/cinder.conf 
osapi_max_limit = 9

monitor csi-attacher logs:

$ oc logs -n openshift-cluster-csi-drivers -c csi-attacher -l app=openstack-cinder-csi-driver-controller -f

Apply extra_pvc.yaml and wait for logs:

I1011 15:51:32.778134       1 csi_handler.go:251] Attaching "csi-09e81a6952f9cf50e21ae5200e4eb4a6aa64aa3c503a7630f96fce6830156318"                                                                                                           
I1011 15:51:37.001918       1 csi_handler.go:264] Attached "csi-09e81a6952f9cf50e21ae5200e4eb4a6aa64aa3c503a7630f96fce6830156318"                                                                                                            
I1011 15:51:39.313697       1 csi_handler.go:251] Attaching "csi-49a90b1a1c687833a37598537b4f8c52ae9681d896be3ebf82e4951612e424b7"                                                                                                           
I1011 15:51:43.774830       1 csi_handler.go:264] Attached "csi-49a90b1a1c687833a37598537b4f8c52ae9681d896be3ebf82e4951612e424b7"                                                                                                            
I1011 15:51:45.387928       1 csi_handler.go:251] Attaching "csi-6c1b8f7fcc39d6c0bbfca515ac949a0918bee404d2ae3b7df39ea2304c3a26fd"                                                                                                           
I1011 15:51:50.080835       1 csi_handler.go:264] Attached "csi-6c1b8f7fcc39d6c0bbfca515ac949a0918bee404d2ae3b7df39ea2304c3a26fd"                                                                                                            
I1011 15:51:50.089211       1 csi_handler.go:251] Attaching "csi-6c1b8f7fcc39d6c0bbfca515ac949a0918bee404d2ae3b7df39ea2304c3a26fd"                                                                                                           
I1011 15:51:50.686071       1 csi_handler.go:264] Attached "csi-6c1b8f7fcc39d6c0bbfca515ac949a0918bee404d2ae3b7df39ea2304c3a26fd"                                                                                                            
I1011 15:52:00.012369       1 csi_handler.go:251] Attaching "csi-9071f4abe5bec3e85cd069ac32907550d00b0b1b7059e20be016077d590d3d4a"                                                                                                           
I1011 15:52:00.016732       1 csi_handler.go:251] Attaching "csi-eef8db4a6832d416dabd1446a25c85872c185589aa3d991a70bb1fffabfaa536"                                                                                                           
I1011 15:52:00.016799       1 csi_handler.go:251] Attaching "csi-a2780cab2d7b73ec5612485acb57bd769c5c007dff1be342671f5bd79fb406bf"                                                                                                           
I1011 15:52:00.016773       1 csi_handler.go:251] Attaching "csi-2428bfad8f93fb52f56bbea701ff7676f7575d8c5a944cb59b8ecc5c3ee1ae46"                                                                                                           
I1011 15:52:00.020131       1 csi_handler.go:251] Attaching "csi-c732f6e51bb026046e3b10bd0804ea94fb4bb4567a218f21520f3537cb1f7323"                                                                                                           
I1011 15:52:00.020712       1 csi_handler.go:251] Attaching "csi-eae77f7818861a33cb2c5c773867dcf856e6024f370570442bd62b11e905348e"                                                                                                           
I1011 15:52:00.020967       1 csi_handler.go:251] Attaching "csi-0f3b6a9da66784dce733317b7d038dfb9e7c12811de84916a79051a7586d2801"                                                                                                           
I1011 15:52:00.021245       1 csi_handler.go:251] Attaching "csi-09287851bc0a0a052c8a52571d4ea576d00864f1a90ed7809ff46854da4b47e4"                                                                                                           
I1011 15:52:00.021711       1 csi_handler.go:251] Attaching "csi-2fe0000cb2bda729aee4986a6bc67f3a26e90fb5031a907ca31cbc5c70d0fcd4"                                                                                                           
I1011 15:52:00.022283       1 csi_handler.go:251] Attaching "csi-6b65dc2d2434b58469d332561c5f3026a45223909b9fe3ce14e91570a3013432"                                                                                                           
I1011 15:52:01.214398       1 request.go:682] Waited for 1.176952213s due to client-side throttling, not priority and fairness, request: PATCH:https://172.30.0.1:443/apis/storage.k8s.io/v1/volumeattachments/csi-6b65dc2d2434b58469d332561c5f3026a45223909b9fe3ce14e91570a3013432
I1011 15:52:04.025624       1 csi_handler.go:264] Attached "csi-2428bfad8f93fb52f56bbea701ff7676f7575d8c5a944cb59b8ecc5c3ee1ae46"                                                                                                            
I1011 15:52:04.035127       1 csi_handler.go:251] Attaching "csi-a570ecd250fb1f3eb30a30db8e839a24a76604b24cc5a62b8d70b511a08e4bc2"                                                                                                           
I1011 15:52:05.771716       1 csi_handler.go:264] Attached "csi-a2780cab2d7b73ec5612485acb57bd769c5c007dff1be342671f5bd79fb406bf"                                                                                                            
I1011 15:52:07.255365       1 csi_handler.go:264] Attached "csi-c732f6e51bb026046e3b10bd0804ea94fb4bb4567a218f21520f3537cb1f7323"                                                                                                            
I1011 15:52:07.263113       1 csi_handler.go:251] Attaching "csi-c732f6e51bb026046e3b10bd0804ea94fb4bb4567a218f21520f3537cb1f7323"                                                                                                           
I1011 15:52:07.880912       1 csi_handler.go:264] Attached "csi-c732f6e51bb026046e3b10bd0804ea94fb4bb4567a218f21520f3537cb1f7323"                                                                                                            
I1011 15:52:09.227733       1 csi_handler.go:264] Attached "csi-0f3b6a9da66784dce733317b7d038dfb9e7c12811de84916a79051a7586d2801"                                                                                                            
I1011 15:52:10.471607       1 csi_handler.go:264] Attached "csi-6b65dc2d2434b58469d332561c5f3026a45223909b9fe3ce14e91570a3013432"                                                                                                            
I1011 15:52:10.480890       1 csi_handler.go:251] Attaching "csi-6b65dc2d2434b58469d332561c5f3026a45223909b9fe3ce14e91570a3013432"                                                                                                           
I1011 15:52:11.069191       1 csi_handler.go:264] Attached "csi-6b65dc2d2434b58469d332561c5f3026a45223909b9fe3ce14e91570a3013432"                                                                                                            
I1011 15:52:12.763717       1 csi_handler.go:264] Attached "csi-eef8db4a6832d416dabd1446a25c85872c185589aa3d991a70bb1fffabfaa536"                                                                                                            
I1011 15:52:12.833384       1 csi_handler.go:264] Attached "csi-9071f4abe5bec3e85cd069ac32907550d00b0b1b7059e20be016077d590d3d4a"                                                                                                            
W1011 15:52:14.285327       1 csi_handler.go:189] VA csi-eae77f7818861a33cb2c5c773867dcf856e6024f370570442bd62b11e905348e for volume 27b018f5-1c6e-4baa-bdbd-7283aa1892bd has attached status false but actual state true. Adding back to VA queue for forced reprocessing
I1011 15:52:15.520360       1 csi_handler.go:264] Attached "csi-eae77f7818861a33cb2c5c773867dcf856e6024f370570442bd62b11e905348e"                                                                                                            
I1011 15:52:15.528733       1 csi_handler.go:251] Attaching "csi-eae77f7818861a33cb2c5c773867dcf856e6024f370570442bd62b11e905348e"                                                                                                           
I1011 15:52:15.667893       1 csi_handler.go:264] Attached "csi-2fe0000cb2bda729aee4986a6bc67f3a26e90fb5031a907ca31cbc5c70d0fcd4"                                                                                                            
I1011 15:52:15.674298       1 csi_handler.go:251] Attaching "csi-2fe0000cb2bda729aee4986a6bc67f3a26e90fb5031a907ca31cbc5c70d0fcd4"                                                                                                           
I1011 15:52:16.157492       1 csi_handler.go:264] Attached "csi-eae77f7818861a33cb2c5c773867dcf856e6024f370570442bd62b11e905348e"                                                                                                            
I1011 15:52:16.279674       1 csi_handler.go:264] Attached "csi-2fe0000cb2bda729aee4986a6bc67f3a26e90fb5031a907ca31cbc5c70d0fcd4"                                                                                                            
I1011 15:52:18.756551       1 csi_handler.go:264] Attached "csi-09287851bc0a0a052c8a52571d4ea576d00864f1a90ed7809ff46854da4b47e4"                                                                                                            
I1011 15:52:18.865630       1 csi_handler.go:264] Attached "csi-a570ecd250fb1f3eb30a30db8e839a24a76604b24cc5a62b8d70b511a08e4bc2"

Note that the logs above shows an occurence of "status false but actual state true", rather than "status true but actual state false", which is what was reported in the bug. After analysis, we conclude that there should be no impact on such a reprocessing - this is rather an indication that main loop of the attacher is processing that VA.

/label qe-approved

openshift-ci-robot · 2023-10-11T15:54:11Z

@mandre: Jira Issue OCPBUGS-20133 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

Replaces #208
Conflicts:
     OWNERS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rlobillo · 2023-10-11T15:55:03Z

/jira refresh

openshift-ci-robot · 2023-10-11T15:55:05Z

@rlobillo: Jira Issue OCPBUGS-20133 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-infra-cherrypick-robot and others added 6 commits July 26, 2023 17:50

fix gate (kubernetes#2313)

ff1b8f5

Co-authored-by: jichenjc <jichenjc@cn.ibm.com>

[release-1.26] [cinder-csi-plugin]: fix pagination, avoid unnecessary…

1f5f88c

… memory allocation, add more logs (kubernetes#2309) * avoid unnecessary memory allocation with more logs * Fix pagination parsing --------- Co-authored-by: kayrus <kay.diam@gmail.com>

Add dulek and kayrus as approvers (kubernetes#2318) (kubernetes#2330)

c1a94a0

Co-authored-by: Matthew Booth <mbooth@redhat.com>

[occm] add max_retries_down support for octavia health monitors (ku…

9c1cf73

…bernetes#2372) (kubernetes#2381)

Merge remote-tracking branch 'k8s/release-1.26' into sync-4.13

983159c

Conflicts: OWNERS

openshift-ci bot requested review from dulek and gryf October 5, 2023 10:19

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2023

mandre mentioned this pull request Oct 5, 2023

Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13 #208

Closed

openshift-ci bot changed the title ~~Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13~~ OCPBUGS-20133: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13 Oct 5, 2023

mandre commented Oct 10, 2023

View reviewed changes

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 10, 2023

openshift-ci bot assigned eurijon, itzikb-redhat and rlobillo Oct 10, 2023

gryf approved these changes Oct 11, 2023

View reviewed changes

openshift-ci bot assigned gryf Oct 11, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023

openshift-ci bot changed the title ~~OCPBUGS-20133: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13~~ OCPBUGS-20133, FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13 Oct 11, 2023

openshift-ci bot changed the title ~~OCPBUGS-20133, FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13~~ OCPBUGS-20133: FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13 Oct 11, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 11, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 11, 2023

openshift-ci bot merged commit d755de2 into openshift:release-4.13 Oct 11, 2023
6 checks passed

mandre deleted the sync-4.13 branch October 11, 2023 15:24

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-20133: FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13 #221

OCPBUGS-20133: FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13 #221

mandre commented Oct 5, 2023

dulek commented Oct 5, 2023

openshift-ci-robot commented Oct 5, 2023

dulek commented Oct 5, 2023

openshift-ci-robot commented Oct 5, 2023

mandre commented Oct 5, 2023

mandre commented Oct 5, 2023

openshift-ci bot commented Oct 5, 2023

mandre left a comment

gryf left a comment

openshift-ci bot commented Oct 11, 2023

dulek commented Oct 11, 2023

openshift-ci-robot commented Oct 11, 2023

dulek commented Oct 11, 2023

openshift-ci-robot commented Oct 11, 2023

rlobillo commented Oct 11, 2023

openshift-ci-robot commented Oct 11, 2023

openshift-ci-robot commented Oct 11, 2023

rlobillo commented Oct 11, 2023

openshift-ci-robot commented Oct 11, 2023

rlobillo commented Oct 11, 2023

openshift-ci-robot commented Oct 11, 2023

OCPBUGS-20133: FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13 #221

OCPBUGS-20133: FastFix: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.26 into release-4.13 #221

Conversation

mandre commented Oct 5, 2023

dulek commented Oct 5, 2023

openshift-ci-robot commented Oct 5, 2023

dulek commented Oct 5, 2023

openshift-ci-robot commented Oct 5, 2023

mandre commented Oct 5, 2023

mandre commented Oct 5, 2023

openshift-ci bot commented Oct 5, 2023

mandre left a comment

Choose a reason for hiding this comment

gryf left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Oct 11, 2023

dulek commented Oct 11, 2023

openshift-ci-robot commented Oct 11, 2023

dulek commented Oct 11, 2023

openshift-ci-robot commented Oct 11, 2023

rlobillo commented Oct 11, 2023

openshift-ci-robot commented Oct 11, 2023

openshift-ci-robot commented Oct 11, 2023

rlobillo commented Oct 11, 2023

openshift-ci-robot commented Oct 11, 2023

rlobillo commented Oct 11, 2023

openshift-ci-robot commented Oct 11, 2023