OCPBUGS-13680: Allow changing cluster-name on existing deployments

[dulek]

We've deployed clusters configuring CCM with the default --cluster-name=kubernetes and this created issues when there are multiple clusters running on a single tenant - if namespace and service names were colliding, there's no way CCM was able to figure out which LB is which and both deployments "stole" LBs from each other.

This commit aims at allowing to change the cluster-name on a running environment and handling all the renames of the LB resources and their tags. A patch updating CCCMO to configure --cluster-name=<InfrastructureName> is prepared as well in cluster-cloud-controller-manager-operator#337.

[dulek]

/retest

Looks pretty much unrelated.

[pierreprinetti]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [dulek,pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@dulek: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@dulek: This pull request references Jira Issue OCPBUGS-13680, which is invalid:

• expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

We've deployed clusters configuring CCM with the default --cluster-name=kubernetes and this created issues when there are multiple clusters running on a single tenant - if namespace and service names were colliding, there's no way CCM was able to figure out which LB is which and both deployments "stole" LBs from each other.

This commit aims at allowing to change the cluster-name on a running environment and handling all the renames of the LB resources and their tags. A patch updating CCCMO to configure --cluster-name=<InfrastructureName> is prepared as well in cluster-cloud-controller-manager-operator#337.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dulek]

/jira refresh

[openshift-ci-robot]

@dulek: This pull request references Jira Issue OCPBUGS-13680, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@dulek: Jira Issue OCPBUGS-13680: Some pull requests linked via external trackers have merged:

• openshift/cloud-provider-openstack#276

The following pull requests linked via external trackers have not merged:

• openshift/cluster-cloud-controller-manager-operator#337 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-13680 has not been moved to the MODIFIED state.

In response to this:

We've deployed clusters configuring CCM with the default --cluster-name=kubernetes and this created issues when there are multiple clusters running on a single tenant - if namespace and service names were colliding, there's no way CCM was able to figure out which LB is which and both deployments "stole" LBs from each other.

This commit aims at allowing to change the cluster-name on a running environment and handling all the renames of the LB resources and their tags. A patch updating CCCMO to configure --cluster-name=<InfrastructureName> is prepared as well in cluster-cloud-controller-manager-operator#337.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build csi-driver-manila-container-v4.16.0-202404101645.p0.g5340eaa.assembly.stream.el9 for distgit csi-driver-manila.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-04-13-070448