OCPBUGS-13680: Pass --cluster-name to OpenStack CCM #337
Conversation
|
/hold Needs to wait for the upstream PR to be merged and synced into downstream first. |
openshift-ci
bot
added
the
do-not-merge/hold
|
@stephenfin, @gryf - please take a look. It's not merging yet, but I'd like you to be aware of this. |
By an terrible oversight, since the in-tree, OpenStack cloud provider was run without passing `--cluster-name` argument, meaning that it just used the default of "kubernetes" as the cluster name when constructing the names of the LB resources. Obviously this led to conflicts when there were multiple OCP clusters in a single OpenStack tenant and it's still a challenge for example for QE running tests on a single cloud. This issue couldn't be fixed easily, because we haven't had an upgrade story solved. Now kubernetes/cloud-provider-openstack#2552 is an attempt to make CCM rename the LBs when the cluster-name is reconfigured. This should allow us to finally solve the name conflict issues. This commit makes sure that CCMO deploys OpenStack CCM passing `--cluster-name`.
dulek
force-pushed
the
openstack-cluster-name
branch
from
0f515c1
to
7b95787
Compare
|
/retest |
|
/test unit |
|
@dulek: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
dulek
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@dulek: This pull request references Jira Issue OCPBUGS-13680, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@dulek: This pull request references Jira Issue OCPBUGS-13680, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
The CPO change is merged downstream in cloud-provider-openstack#276, so this is good to go. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 70aa31a
into
openshift:master
|
@dulek: Jira Issue OCPBUGS-13680: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-13680 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.16.0-202404121812.p0.g70aa31a.assembly.stream.el9 for distgit ose-cluster-cloud-controller-manager-operator. |
|
Fix included in accepted release 4.16.0-0.nightly-2024-04-13-070448 |
By an terrible oversight, since the in-tree, OpenStack cloud provider was run without passing
--cluster-nameargument, meaning that it just used the default of "kubernetes" as the cluster name when constructing the names of the LB resources. Obviously this led to conflicts when there were multiple OCP clusters in a single OpenStack tenant and it's still a challenge for example for QE running tests on a single cloud.This issue couldn't be fixed easily, because we haven't had an upgrade story solved. Now kubernetes/cloud-provider-openstack#2552 is an attempt to make CCM rename the LBs when the cluster-name is reconfigured. This should allow us to finally solve the name conflict issues.
This commit makes sure that CCMO deploys OpenStack CCM passing
--cluster-name.