New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.7] Bug 1933659: Add udev to the driver image #46
[release-4.7] Bug 1933659: Add udev to the driver image #46
Conversation
NodeStage / NodePublish need to call "udevadm trigger".
@openshift-cherrypick-robot: Bugzilla bug 1930220 has been cloned as Bugzilla bug 1933659. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1933659, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-openstack |
@jsafrane: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jsafrane there is no e2e job for this repo |
@@ -1,13 +1,13 @@ | |||
FROM registry.svc.ci.openshift.org/openshift/builder:rhel-8-golang-openshift-4.6 | |||
FROM registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.15-openshift-4.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt this be 4.7?
COPY . /go/src/k8s.io/cloud-provider-openstack | ||
RUN cd /go/src/k8s.io/cloud-provider-openstack && \ | ||
go build -o cinder-csi-plugin cmd/cinder-csi-plugin/main.go | ||
|
||
FROM registry.svc.ci.openshift.org/openshift/4.6:base | ||
FROM registry.ci.openshift.org/ocp/4.8:base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt this be 4.7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Patch-Manager) I am confused why this is referencing 4.8 base images and not 4.7.
/hold |
So, how do I change PR created by cherry-pick bot? I created a new PR: #47 /close |
@jsafrane: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1933659. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #45
/assign jsafrane