Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.7] Bug 1933659: Add udev to the driver image #46

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #45

/assign jsafrane

NodeStage / NodePublish need to call "udevadm trigger".
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Bugzilla bug 1930220 has been cloned as Bugzilla bug 1933659. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1933659: Add udev to the driver image

In response to this:

[release-4.7] Bug 1930220: Add udev to the driver image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.7] Bug 1930220: Add udev to the driver image [release-4.7] Bug 1933659: Add udev to the driver image Mar 1, 2021
Copy link

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Mar 1, 2021
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1933659, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1930220 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1930220 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

In response to this:

[release-4.7] Bug 1933659: Add udev to the driver image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 1, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 1, 2021
@jsafrane
Copy link

jsafrane commented Mar 1, 2021

/test e2e-openstack
?

@openshift-ci-robot
Copy link

@jsafrane: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test images
  • /test unit

Use /test all to run all jobs.

In response to this:

/test e2e-openstack
?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link

Fedosin commented Mar 1, 2021

@jsafrane there is no e2e job for this repo

@@ -1,13 +1,13 @@
FROM registry.svc.ci.openshift.org/openshift/builder:rhel-8-golang-openshift-4.6
FROM registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.15-openshift-4.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt this be 4.7?

COPY . /go/src/k8s.io/cloud-provider-openstack
RUN cd /go/src/k8s.io/cloud-provider-openstack && \
go build -o cinder-csi-plugin cmd/cinder-csi-plugin/main.go

FROM registry.svc.ci.openshift.org/openshift/4.6:base
FROM registry.ci.openshift.org/ocp/4.8:base
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt this be 4.7?

Copy link
Member

@derekwaynecarr derekwaynecarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Patch-Manager) I am confused why this is referencing 4.8 base images and not 4.7.

@mandre
Copy link
Member

mandre commented Mar 8, 2021

/hold
This needs correct 4.7 image reference as Derek noted.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2021
@jsafrane
Copy link

jsafrane commented Mar 8, 2021

So, how do I change PR created by cherry-pick bot? I created a new PR: #47

/close

@openshift-ci-robot
Copy link

@jsafrane: Closed this PR.

In response to this:

So, how do I change PR created by cherry-pick bot? I created a new PR: #47

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1933659. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

[release-4.7] Bug 1933659: Add udev to the driver image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants