Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge https://github.com/kubernetes/cloud-provider-openstack:master into master #69

Closed
wants to merge 4 commits into from
Closed

Merge https://github.com/kubernetes/cloud-provider-openstack:master into master #69

wants to merge 4 commits into from

Conversation

shiftstack-merge-bot[bot]
Copy link

No description provided.

gman0 and others added 2 commits July 22, 2021 22:11
@gman0
[manila-csi-plugin] Add options for passing mount opts to cephfs-csi (k…
f1848cd 
…ubernetes#1605)

* added cephfs-csi mount opts to volume context

This commit adds two new options specific to cephfs-csi
to ControllerVolumeContext and NodeVolumeContext:
* cephfs-kernelMountOptions,
* cephfs-fuseMountOptions

* pass cephfs-kernelMountOptions and cephfs-fuseMountOptions to cephfs-csi

* updated docs with new volume context opts
@ramineni
[cinder-csi-plugin] Remove redundant imagePullPolicy (kubernetes#1602)
2155ee9
@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shiftstack-merge-bot[bot]
To complete the pull request process, please assign alexander-demichev after the PR has been reviewed.
You can assign the PR to them by writing /assign @alexander-demichev in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from adduarte and mdbooth July 26, 2021 12:05
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 26, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2021

Hi @shiftstack-merge-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Jul 26, 2021

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2021
@mandre
Copy link
Member

mandre commented Aug 3, 2021

/retest

2 similar comments
@mandre
Copy link
Member

mandre commented Aug 6, 2021

/retest

@pierreprinetti
Copy link
Member

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 19, 2021

@shiftstack-merge-bot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack-csi-manila 18928cc link /test e2e-openstack-csi-manila

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Member

/hold
We should probably merge the 1.22 tag instead

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2021
@pierreprinetti
Copy link
Member

/close
Superseded by #70

@openshift-ci openshift-ci bot closed this Aug 20, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 20, 2021

@pierreprinetti: Closed this PR.

In response to this:

/close
Superseded by #70

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the merge-bot-master branch August 20, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adduarte adduarte Awaiting requested review from adduarte

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mandre @pierreprinetti @gman0 @ramineni