Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ose-powervs-cloud-controller-manager images to be consistent with ART #39

Conversation

openshift-bot
Copy link

@openshift-bot openshift-bot commented Jun 5, 2023

Updating ose-powervs-cloud-controller-manager images to be consistent with ART
TLDR:
Component owners, please ensure that this PR merges as it impacts the fidelity
of your CI signal. Patch-manager / leads, this PR is a no-op from a product
perspective -- feel free to manually apply any labels (e.g. jira/valid-bug) to help the
PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is
to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test
to remove this tag and help the PR to merge.

Detail:
This repository is out of sync with the downstream product builds for this component.
One or more images differ from those being used by ART to create product builds. This
should be addressed to ensure that the component's CI testing is accurately
reflecting what customers will experience.

The information within the following ART component metadata is driving this alignment
request: ose-powervs-cloud-controller-manager.yml.

The vast majority of these PRs are opened because a different Golang version is being
used to build the downstream component. ART compiles most components with the version
of Golang being used by the control plane for a given OpenShift release. Exceptions
to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift
architecture team and communicated to the ART team.

Roles & Responsibilities:

  • Component owners are responsible for ensuring these alignment PRs merge with passing
    tests OR that necessary metadata changes are reported to the ART team: @release-artists
    in #aos-art on Slack. If necessary, the changes required by this pull request can be
    introduced with a separate PR opened by the component team. Once the repository is aligned,
    this PR will be closed automatically.
  • Patch-manager or those with sufficient privileges within this repository may add
    any required labels to ensure the PR merges once tests are passing. Downstream builds
    are already being built with these changes. Merging this PR only improves the fidelity
    of our CI.

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
  from_repository: true

If you have any questions about this pull request, please reach out to @release-artists in the #aos-art coreos slack channel.

@openshift-bot openshift-bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jun 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-bot
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RadekManak
Copy link
Contributor

/hold
openshift/release#39915 should merge first, and then this PR should be incorporated in the kube 1.27 rebase PR.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2023
@mkumatag
Copy link
Member

mkumatag commented Jun 6, 2023

/retest

@RadekManak
Copy link
Contributor

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

@openshift-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test 6384cfd link true /test test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Karthik-K-N
Copy link
Member

For this to pass we need to set

GOCOVERDIR := .

in Make file.

but this PR is already incroporated in #35 but that is not able to get the latest go version.

@RadekManak
Copy link
Contributor

You will need to fix the rebase PR to make sure the files have the latest go versions.

@Karthik-K-N
Copy link
Member

You will need to fix the rebase PR to make sure the files have the latest go versions.

The rebase PR #35 has the latest go only: https://github.com/Karthik-K-N/cloud-provider-powervs/blob/merge-2023-06-01/.ci-operator.yaml, Not sure whats is being missed.

@RadekManak
Copy link
Contributor

RadekManak commented Jun 6, 2023

The CI runs on merge of the pull requests to base branch. I bet that after it merges, the changes from main take precedence. You have to redo the rebase with the downgrade commits from main dropped.

@Karthik-K-N
Copy link
Member

Karthik-K-N commented Jun 6, 2023

Incorporated this changes as a part of rebase PR: #40

/hold

@Karthik-K-N
Copy link
Member

/close

@openshift-ci openshift-ci bot closed this Jun 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

@Karthik-K-N: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants