Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powervs-ccm: Use from_repository setting #39915

Conversation

RadekManak
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@RadekManak: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cloud-provider-powervs-main-fmt openshift/cloud-provider-powervs presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-powervs-main-images openshift/cloud-provider-powervs presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-powervs-main-test openshift/cloud-provider-powervs presubmit Ci-operator config changed
pull-ci-openshift-cloud-provider-powervs-main-vet openshift/cloud-provider-powervs presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@RadekManak
Copy link
Contributor Author

/pj-rehearse

@Karthik-K-N
Copy link
Member

I see the test is failing because error message mismatch due to env variable being not set

ibm_loadbalancer_test.go:1662: Expected Error: 'Error running calicoctl: resource does not exist: bla bla bla, exit status 1'. Actual Error: 'Error running calicoctl: resource does not exist: bla bla blawarning: GOCOVERDIR not set, no coverage data emitted

and I also see that the in the new PR its being set https://github.com/openshift/cloud-provider-powervs/pull/35/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52

How to handle this scenario? Can we override this error and merge it. Or should we submit a PR to add the environmetal variable .

@RadekManak
Copy link
Contributor Author

RadekManak commented Jun 1, 2023

Here's what we are going to do:

  1. Revert .ci-operator.yaml image to the one currently being used https://github.com/openshift/cloud-provider-powervs/pull/36/files
  2. This pull requests should be able to merge
  3. Revert back to go 1.20 in the rebase to kube 1.27

@RadekManak
Copy link
Contributor Author

/pj-rehearse

@Karthik-K-N
Copy link
Member

Seems like image is not available

 * could not resolve inputs: could not determine inputs for step [input:root]: could not resolve base image from openshift/release:rhel-8-golang-1.18-openshift-4.11: imagestreamtags.image.openshift.io "release:rhel-8-golang-1.18-openshift-4.11" not found

@Karthik-K-N
Copy link
Member

/retest-required

@Karthik-K-N
Copy link
Member

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@Karthik-K-N, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: invalid configuration: tests[75]: invalid cluster profile "oci-assisted"

If the problem persists, please contact Test Platform.

@RadekManak
Copy link
Contributor Author

/pj-rehearse

@RadekManak
Copy link
Contributor Author

/pj-rehearse ack

@Karthik-K-N
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Karthik-K-N, RadekManak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

@RadekManak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 068cf29 into openshift:master Jun 6, 2023
22 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

@RadekManak: Updated the following 3 configmaps:

  • ci-operator-main-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cloud-provider-powervs-main.yaml using file ci-operator/config/openshift/cloud-provider-powervs/openshift-cloud-provider-powervs-main.yaml
  • job-config-main-postsubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cloud-provider-powervs-main-postsubmits.yaml using file ci-operator/jobs/openshift/cloud-provider-powervs/openshift-cloud-provider-powervs-main-postsubmits.yaml
  • job-config-main-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cloud-provider-powervs-main-presubmits.yaml using file ci-operator/jobs/openshift/cloud-provider-powervs/openshift-cloud-provider-powervs-main-presubmits.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants