Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2184: Merge https://github.com/kubernetes/cloud-provider-vsphere:master (ff83354) into master #42

Merged

Conversation

cloud-team-rebase-bot[bot]
Copy link

No description provided.

testwill and others added 6 commits June 25, 2023 11:37
Signed-off-by: Ananda Gollapudi <ananda.gollapudi@fmr.com>
…to kep2392

Signed-off-by: Ananda Gollapudi <ananda.gollapudi@fmr.com>
…ne number

Signed-off-by: Ananda Gollapudi <ananda.gollapudi@fmr.com>
chore: remove refs to deprecated io/ioutil
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2023

Hi @cloud-team-rebase-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/kubernetes/cloud-provider-vsphere:master (49b194c) into master Merge https://github.com/kubernetes/cloud-provider-vsphere:master (a6cbba3) into master Jul 20, 2023
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch 2 times, most recently from 6336ce4 to 72e520f Compare July 24, 2023 12:55
briantopping and others added 3 commits August 2, 2023 19:38
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/kubernetes/cloud-provider-vsphere:master (a6cbba3) into master Merge https://github.com/kubernetes/cloud-provider-vsphere:master (5801615) into master Aug 7, 2023
lobziik and others added 16 commits November 9, 2023 12:53
Added Openshift specific builds scripts, linter/tests/etc
runners. Extended makefile with OCP specific targets.

Upstream version of lint, and fmt pollutes
go.mod and go.sum files, so, own versions of such scripts was
introduced.
…ents

OCP build system does expect *.assembly.stream.json and
build system specific Dockerfile files to be copied into the build container.
Remove respective entries from the .dockerignore to satisfy this requirement.
In some cases, upstream commits were included in the git log command, causing the verify-git-history test to fail because the commits did not follow name rules.
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/kubernetes/cloud-provider-vsphere:master (81ad960) into master Merge https://github.com/kubernetes/cloud-provider-vsphere:master (ff83354) into master Nov 9, 2023
Copy link

openshift-ci bot commented Nov 9, 2023

@cloud-team-rebase-bot[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed JoelSpeed changed the title Merge https://github.com/kubernetes/cloud-provider-vsphere:master (ff83354) into master OCPCLOUD-2184: Merge https://github.com/kubernetes/cloud-provider-vsphere:master (ff83354) into master Nov 10, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 10, 2023

@cloud-team-rebase-bot[bot]: This pull request references OCPCLOUD-2184 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2023
Copy link

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 3d5cdbd into openshift:master Nov 10, 2023
7 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-vsphere-cloud-controller-manager-container-v4.15.0-202311202349.p0.g3d5cdbd.assembly.stream for distgit ose-vsphere-cloud-controller-manager.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet