New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPCLOUD-2184: Merge https://github.com/kubernetes/cloud-provider-vsphere:master (ff83354) into master #42
OCPCLOUD-2184: Merge https://github.com/kubernetes/cloud-provider-vsphere:master (ff83354) into master #42
Conversation
Signed-off-by: Ananda Gollapudi <ananda.gollapudi@fmr.com>
…to kep2392 Signed-off-by: Ananda Gollapudi <ananda.gollapudi@fmr.com>
…ne number Signed-off-by: Ananda Gollapudi <ananda.gollapudi@fmr.com>
chore: remove refs to deprecated io/ioutil
Hi @cloud-team-rebase-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The vcsim 'RegisterEndpoints' flag was added after the initial version of vsphere_test was written. With the flag set, tests only need to import the simulator packages it needs.
Simplify vcsim endpoint setup
…0.30.6 Bump govmomi to 0.30.6
…or_e2e Bump dependency in e2e test
Improve helm chart to support global values
Bump version to 1.27.0
Add helm 1.27.0
6336ce4
to
72e520f
Compare
Use floating versions
changes_to_fix_broken_links_on_refactor_design_document
Update Dockerfile
Added Openshift specific builds scripts, linter/tests/etc runners. Extended makefile with OCP specific targets. Upstream version of lint, and fmt pollutes go.mod and go.sum files, so, own versions of such scripts was introduced.
…ents OCP build system does expect *.assembly.stream.json and build system specific Dockerfile files to be copied into the build container. Remove respective entries from the .dockerignore to satisfy this requirement.
In some cases, upstream commits were included in the git log command, causing the verify-git-history test to fail because the commits did not follow name rules.
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
b5025e7
to
c2de4a5
Compare
@cloud-team-rebase-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@cloud-team-rebase-bot[bot]: This pull request references OCPCLOUD-2184 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-vsphere-cloud-controller-manager-container-v4.15.0-202311202349.p0.g3d5cdbd.assembly.stream for distgit ose-vsphere-cloud-controller-manager. |
No description provided.