OCPBUGS-15154: Scope secret informers per namespace

[JoelSpeed]

The current implementation uses cluster scoped secret informers which, means you need much wider permissions than you would otherwise need, given the controller is looking at only a handful of secrets.
This is an attempt to reduce that scope and allow a much stricter RBAC requirement.

Upstream PR kubernetes#737

[openshift-ci-robot]

@JoelSpeed: This pull request references Jira Issue OCPBUGS-15154, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The current implementation uses cluster scoped secret informers which, means you need much wider permissions than you would otherwise need, given the controller is looking at only a handful of secrets.
This is an attempt to reduce that scope and allow a much stricter RBAC requirement.

Upstream PR kubernetes#737

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

/retest

[elmiko]

this generally makes sense and lgtm, do you want to merge here and let the upstream handle itself @JoelSpeed ?

/lgtm
/retest

[JoelSpeed]

/retest

[JoelSpeed]

/retest
/approve

It's important to OpenShift to minimise these permissions, will work with upstream to make sure that we either get this patch merged, or, if not, make a plan for carrying this through future releases

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@JoelSpeed: Jira Issue OCPBUGS-15154: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/cluster-cloud-controller-manager-operator#259 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-15154 has not been moved to the MODIFIED state.

In response to this:

The current implementation uses cluster scoped secret informers which, means you need much wider permissions than you would otherwise need, given the controller is looking at only a handful of secrets.
This is an attempt to reduce that scope and allow a much stricter RBAC requirement.

Upstream PR kubernetes#737

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-vsphere-cloud-controller-manager-container-v4.14.0-202311211133.p0.ga24e171.assembly.stream for distgit ose-vsphere-cloud-controller-manager.
All builds following this will include this PR.