Bug 1798597: [release-4.3] take into consideration all instance states for deletion

[enxebre]

This fix deletion to take into consideration all instance states when deleting.
Otherwise instances with a provider state different than running will be leaked when deleting a machine.

Manual cherry-pick of #291 to resolve conflicts.

[openshift-ci-robot]

@enxebre: This pull request references Bugzilla bug 1798597, which is invalid:

• expected the bug to target the "4.3.z" release, but it targets "4.3.0" instead
• expected dependent Bugzilla bug 1798596 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1798597: [release-4.3] Fix deletion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enxebre]

/bugzilla refresh

[openshift-ci-robot]

@enxebre: This pull request references Bugzilla bug 1798597, which is invalid:

• expected dependent Bugzilla bug 1798596 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enxebre]

/retest

[bison]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@enxebre: This pull request references Bugzilla bug 1798597, which is invalid:

• expected dependent Bugzilla bug 1798596 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1798597: [release-4.3] Fix deletion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@enxebre: This pull request references Bugzilla bug 1798597, which is invalid:

• expected dependent Bugzilla bug 1798596 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1798597: [release-4.3] take into consideration all instance states for deletion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enxebre]

/bugzilla refresh

[openshift-ci-robot]

@enxebre: This pull request references Bugzilla bug 1798597, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enxebre]

cc @mfojtik

[openshift-ci-robot]

@enxebre: All pull requests linked via external trackers have merged. Bugzilla bug 1798597 has been moved to the MODIFIED state.

In response to this:

Bug 1798597: [release-4.3] take into consideration all instance states for deletion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.