-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG 1866778: [aws] mapi_instance_create_failed doesn't work on aws #346
BUG 1866778: [aws] mapi_instance_create_failed doesn't work on aws #346
Conversation
@Danil-Grigorev: This pull request references Bugzilla bug 1866778, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one potential nit though, wdyt?
pkg/actuators/machine/instances.go
Outdated
@@ -15,6 +15,7 @@ import ( | |||
"github.com/openshift/machine-api-operator/pkg/metrics" | |||
"k8s.io/klog" | |||
awsproviderv1 "sigs.k8s.io/cluster-api-provider-aws/pkg/apis/awsprovider/v1beta1" | |||
k8sclient "sigs.k8s.io/controller-runtime/pkg/client" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to import this as ctrlclient
as we have done elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed @JoelSpeed, PTAL.
This ensures none API call error will sneak unreported by the metrics.
b0af23a
to
25e0934
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/lgtm |
@Danil-Grigorev: All pull requests linked via external trackers have merged: Bugzilla bug 1866778 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Propagate AWS metrics to all API calls
This ensures none API call error will sneak unreported
by the metrics.