Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-1872: Merge https://github.com/kubernetes-sigs/cluster-api-provider-aws:v2.1.2 (4c6b62f) into master #464

Closed
wants to merge 374 commits into from

Conversation

damdo
Copy link
Member

@damdo damdo commented May 23, 2023

No description provided.

k8s-ci-robot and others added 30 commits February 6, 2023 06:13
…ot/go_modules/github.com/aws/amazon-vpc-cni-k8s-1.12.2

build(deps): bump github.com/aws/amazon-vpc-cni-k8s from 1.12.1 to 1.12.2
Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
Co-authored-by: Andreas Sommer <andreas.sommer87@googlemail.com>
…-tools

Bump controller-tools in /hack/tools
…_name_tag

Allow user to specify the Name tag value for AWS tags
Remove unnecessary `.AnyTimes()` mock calls for unmanaged VPC test
…apping roles

chore: refactor getting roles to be inline with PR review

test: adds an integration test to test getting roles logic
…-profiles

fix: use instance profiles of machine pools and machine deployments for mapping roles
…ondition

Fix error condition on eventually
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.6.0 to 0.7.0.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.6.0...v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Johannes Frey <johannes.frey@mercedes-benz.com>
…-sigs#4059)

* Cleanup AWS CloudFormation stack in Test environment

* add security group name to the output
[E2E] Fix service quotas for EventBridge rules
…-listeners-unit-test

Fix error print statement for ELBv2 listeners test
…ot/go_modules/golang.org/x/text-0.7.0

build(deps): bump golang.org/x/text from 0.6.0 to 0.7.0
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.5.0 to 0.6.0.
- [Release notes](https://github.com/golang/crypto/releases)
- [Commits](golang/crypto@v0.5.0...v0.6.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…ot/go_modules/golang.org/x/crypto-0.6.0

build(deps): bump golang.org/x/crypto from 0.5.0 to 0.6.0
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.8.0 to 2.8.1.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.8.0...v2.8.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…ot/go_modules/github.com/onsi/ginkgo/v2-2.8.1

build(deps): bump github.com/onsi/ginkgo/v2 from 2.8.0 to 2.8.1
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
…on_reconcile

chore(ref): add more robustness to cloudformation stack create in tests
alexander-demicev and others added 14 commits May 23, 2023 17:33
# Conflicts:
#	.github/workflows/codeql-analysis.yml
#	.github/workflows/dependabot.yml
#	OWNERS_ALIASES

# Conflicts:
#	.github/PULL_REQUEST_TEMPLATE.md
#	.github/workflows/codeql-analysis.yml
#	.github/workflows/dependabot.yml
#	OWNERS_ALIASES
# Conflicts:
#	.github/workflows/codeql-analysis.yml
#	.github/workflows/dependabot.yml
#	OWNERS_ALIASES
@openshift-ci openshift-ci bot requested review from elmiko and JoelSpeed May 23, 2023 15:34
@openshift-ci
Copy link

openshift-ci bot commented May 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from damdo. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo
Copy link
Member Author

damdo commented May 23, 2023

/retest

@damdo
Copy link
Member Author

damdo commented May 23, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2023
@damdo damdo changed the title Merge https://github.com/kubernetes-sigs/cluster-api-provider-aws:v2.1.2 (4c6b62f) into master OCPCLOUD-1872: Merge https://github.com/kubernetes-sigs/cluster-api-provider-aws:v2.1.2 (4c6b62f) into master Jun 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 2, 2023

@damdo: This pull request references OCPCLOUD-1872 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 2, 2023
@enxebre
Copy link
Member

enxebre commented Jun 8, 2023

/test e2e-hypershift

1 similar comment
@enxebre
Copy link
Member

enxebre commented Jun 14, 2023

/test e2e-hypershift

@openshift-ci
Copy link

openshift-ci bot commented Jun 14, 2023

@damdo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift cef6e15 link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@damdo
Copy link
Member Author

damdo commented Jul 10, 2023

Superseded by #472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet