OCPCLOUD-2257: Use manifests generation tool from provider repo

[damdo]

This PR implements the provider part of the work defined in the Installing Cluster API components in OpenShift enhancement.

Notably it:

• adds (vendors in) a manifests-gen tool hosted as a separate module under the cluster-capi-operator repo
• extends a Make target to invoke the tool
• creates an openshift/manifests dir where the generated manifests will be dumped and extends the Dockerfile to load the content of this directory in the payload image accordingly (these manifests will then be deployed by the CVO).

Note:

• After this PR merges, and after OCPCLOUD-2256,OCPCLOUD-2255: refactor: remove cluster-api-operator, rework assets/manifests cluster-capi-operator#121 merges, we will need to re-vendor the manifests-gen tool.

Manual testing for this combination of PRs ✅ PASSED: see here:

• OCPCLOUD-2256,OCPCLOUD-2255: refactor: remove cluster-api-operator, rework assets/manifests cluster-capi-operator#121
• OCPCLOUD-2257: Use manifests generation tool from provider repo #471
• OCPCLOUD-2257: Use manifests generation tool from provider repo cluster-api#179 (this PR)

[openshift-ci-robot]

@damdo: This pull request references OCPCLOUD-2257 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@damdo: This pull request references OCPCLOUD-2257 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR implements the provider part of the work defined in the Installing Cluster API components in OpenShift enhancement.

Notably it:

• adds (vendors in) a manifests-generation tool hosted as a separate module under the cluster-capi-operator repo
• extends a Make target to invoke the tool
• creates an openshift/manifests dir where the generated manifests will be dumped and extends the Dockerfile to load the content of this directory in the payload image accordingly (these manifests will then be deployed by the CVO).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@damdo: This pull request references OCPCLOUD-2257 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR implements the provider part of the work defined in the Installing Cluster API components in OpenShift enhancement.

Notably it:

• adds (vendors in) a manifests-generation tool hosted as a separate module under the cluster-capi-operator repo
• extends a Make target to invoke the tool
• creates an openshift/manifests dir where the generated manifests will be dumped and extends the Dockerfile to load the content of this directory in the payload image accordingly (these manifests will then be deployed by the CVO).

Note:

• After this PR merges, and after OCPCLOUD-2256,OCPCLOUD-2255: refactor: remove cluster-api-operator, rework assets/manifests cluster-capi-operator#121 merges, we will need to re-vendor the manifests-generation tool.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[damdo]

/hold
until happy with manual testing

[openshift-ci-robot]

@damdo: This pull request references OCPCLOUD-2257 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR implements the provider part of the work defined in the Installing Cluster API components in OpenShift enhancement.

Notably it:

• adds (vendors in) a manifests-gen tool hosted as a separate module under the cluster-capi-operator repo
• extends a Make target to invoke the tool
• creates an openshift/manifests dir where the generated manifests will be dumped and extends the Dockerfile to load the content of this directory in the payload image accordingly (these manifests will then be deployed by the CVO).

Note:

• After this PR merges, and after OCPCLOUD-2256,OCPCLOUD-2255: refactor: remove cluster-api-operator, rework assets/manifests cluster-capi-operator#121 merges, we will need to re-vendor the manifests-gen tool.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[damdo]

/retest

[damdo]

Manual e2e testing with a ClusterBot cluster:
launch openshift/cluster-capi-operator#121,openshift/cluster-api-provider-aws#471,openshift/cluster-api#179 aws,techpreview

[~/src/cluster-capi-operator git:(refactor)] $ oc -n openshift-cluster-api get pods
NAME                                       READY   STATUS    RESTARTS      AGE
capa-controller-manager-59fd59867b-g6twb   1/1     Running   1 (16m ago)   22m
capi-controller-manager-5bbf765989-t27xv   1/1     Running   1 (16m ago)   22m
cluster-capi-operator-b66cc849b-rrq6x      1/1     Running   0             26m

[~/src/cluster-capi-operator git:(refactor)] $ make e2e
./hack/test.sh "./e2e/..." 30m
go run ./hack/../vendor/github.com/onsi/ginkgo/v2/ginkgo -r -v --randomize-all --randomize-suites --keep-going --race --trace --timeout=30m ./e2e/...
Running Suite: Cluster API Suite - /Users/ddonati/src/cluster-capi-operator/e2e
===============================================================================
Random Seed: 1700664807 - will randomize all specs

Will run 3 of 3 specs
------------------------------
[BeforeSuite]
/Users/ddonati/src/cluster-capi-operator/e2e/e2e_test.go:49
[BeforeSuite] PASSED [0.826 seconds]
------------------------------
Cluster API AWS MachineSet should be able to run a machine with a default provider spec
/Users/ddonati/src/cluster-capi-operator/e2e/aws_test.go:62
  STEP: Creating core cluster @ 11/22/23 15:53:39.77
  STEP: Creating AWS cluster @ 11/22/23 15:53:40.366
  STEP: Creating AWS machine template @ 11/22/23 15:53:40.957
  STEP: Creating MachineSet "aws-machineset" @ 11/22/23 15:53:41.162
  STEP: Waiting for MachineSet machines "aws-machineset" to enter Running phase @ 11/22/23 15:53:41.372
  STEP: Comparing instances created by MAPI and CAPI @ 11/22/23 15:58:04.622
  STEP: Deleting MachineSet "aws-machineset" @ 11/22/23 15:58:06.264
  STEP: Waiting for MachineSet "aws-machineset" to be deleted @ 11/22/23 15:58:06.461
  STEP: Deleting /aws-machine-template @ 11/22/23 15:59:09.206
• [330.502 seconds]
------------------------------

Ran 1 of 3 Specs in 331.336 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 2 Skipped
PASS

Ginkgo ran 1 suite in 5m41.98215617s
Test Suite Passed

[openshift-ci-robot]

@damdo: This pull request references OCPCLOUD-2257 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR implements the provider part of the work defined in the Installing Cluster API components in OpenShift enhancement.

Notably it:

• adds (vendors in) a manifests-gen tool hosted as a separate module under the cluster-capi-operator repo
• extends a Make target to invoke the tool
• creates an openshift/manifests dir where the generated manifests will be dumped and extends the Dockerfile to load the content of this directory in the payload image accordingly (these manifests will then be deployed by the CVO).

Note:

• After this PR merges, and after OCPCLOUD-2256,OCPCLOUD-2255: refactor: remove cluster-api-operator, rework assets/manifests cluster-capi-operator#121 merges, we will need to re-vendor the manifests-gen tool.

Manual testing for this combination ✅ PASSED: see here:

• OCPCLOUD-2256,OCPCLOUD-2255: refactor: remove cluster-api-operator, rework assets/manifests cluster-capi-operator#121
• OCPCLOUD-2257: Use manifests generation tool from provider repo #471
• OCPCLOUD-2257: Use manifests generation tool from provider repo cluster-api#179 (this PR)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@damdo: This pull request references OCPCLOUD-2257 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR implements the provider part of the work defined in the Installing Cluster API components in OpenShift enhancement.

Notably it:

• adds (vendors in) a manifests-gen tool hosted as a separate module under the cluster-capi-operator repo
• extends a Make target to invoke the tool
• creates an openshift/manifests dir where the generated manifests will be dumped and extends the Dockerfile to load the content of this directory in the payload image accordingly (these manifests will then be deployed by the CVO).

Note:

• After this PR merges, and after OCPCLOUD-2256,OCPCLOUD-2255: refactor: remove cluster-api-operator, rework assets/manifests cluster-capi-operator#121 merges, we will need to re-vendor the manifests-gen tool.

Manual testing for this combination of PRs ✅ PASSED: see here:

• OCPCLOUD-2256,OCPCLOUD-2255: refactor: remove cluster-api-operator, rework assets/manifests cluster-capi-operator#121
• OCPCLOUD-2257: Use manifests generation tool from provider repo #471
• OCPCLOUD-2257: Use manifests generation tool from provider repo cluster-api#179 (this PR)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enxebre]

Failing because of https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-api-provider-aws/471/pull-ci-openshift-cluster-api-provider-aws-master-e2e-hypershift/1727352562639704064
openshift/hypershift#3227

Should go green now
/test e2e-hypershift

[JoelSpeed]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[damdo]

/unhold

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-aws-cluster-api-controllers-container-v4.15.0-202311271455.p0.g98d1fe2.assembly.stream for distgit ose-aws-cluster-api-controllers.
All builds following this will include this PR.