OCPCLOUD-2257: Use manifests generation tool from provider repo

[damdo]

This PR implements the provider part of the work defined in the Installing Cluster API components in OpenShift enhancement.

Notably it:

• adds (vendors in) a manifests-gen tool hosted as a separate module under the cluster-capi-operator repo
• extends a Make target to invoke the tool
• creates an openshift/manifests dir where the generated manifests will be dumped and extends the Dockerfile to load the content of this directory in the payload image accordingly (these manifests will then be deployed by the CVO).

Note:

• After this PR merges, and after OCPCLOUD-2256,OCPCLOUD-2255: refactor: remove cluster-api-operator, rework assets/manifests cluster-capi-operator#121 merges, we will need to re-vendor the manifests-gen tool.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@damdo: This pull request references OCPCLOUD-2257 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@damdo: This pull request references OCPCLOUD-2257 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR implements the provider part of the work defined in the Installing Cluster API components in OpenShift enhancement.

Notably it:

• adds (vendors in) a manifests-generation tool hosted as a separate module under the cluster-capi-operator repo
• extends a Make target to invoke the tool
• creates an openshift/manifests dir where the generated manifests will be dumped and extends the Dockerfile to load the content of this directory in the payload image accordingly (these manifests will then be deployed by the CVO).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@damdo: This pull request references OCPCLOUD-2257 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR implements the provider part of the work defined in the Installing Cluster API components in OpenShift enhancement.

Notably it:

• adds (vendors in) a manifests-generation tool hosted as a separate module under the cluster-capi-operator repo
• extends a Make target to invoke the tool
• creates an openshift/manifests dir where the generated manifests will be dumped and extends the Dockerfile to load the content of this directory in the payload image accordingly (these manifests will then be deployed by the CVO).

After this PR merges, and after openshift/cluster-capi-operator#121 merges, we will need to re-vendor the manifests-generation tool

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@damdo: This pull request references OCPCLOUD-2257 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR implements the provider part of the work defined in the Installing Cluster API components in OpenShift enhancement.

Notably it:

• adds (vendors in) a manifests-generation tool hosted as a separate module under the cluster-capi-operator repo
• extends a Make target to invoke the tool
• creates an openshift/manifests dir where the generated manifests will be dumped and extends the Dockerfile to load the content of this directory in the payload image accordingly (these manifests will then be deployed by the CVO).

Note:

• After this PR merges, and after OCPCLOUD-2256,OCPCLOUD-2255: refactor: remove cluster-api-operator, rework assets/manifests cluster-capi-operator#121 merges, we will need to re-vendor the manifests-generation tool.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[damdo]

/hold
until happy with manual testing

[openshift-ci-robot]

@damdo: This pull request references OCPCLOUD-2257 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR implements the provider part of the work defined in the Installing Cluster API components in OpenShift enhancement.

Notably it:

• adds (vendors in) a manifests-gen tool hosted as a separate module under the cluster-capi-operator repo
• extends a Make target to invoke the tool
• creates an openshift/manifests dir where the generated manifests will be dumped and extends the Dockerfile to load the content of this directory in the payload image accordingly (these manifests will then be deployed by the CVO).

Note:

• After this PR merges, and after OCPCLOUD-2256,OCPCLOUD-2255: refactor: remove cluster-api-operator, rework assets/manifests cluster-capi-operator#121 merges, we will need to re-vendor the manifests-gen tool.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[damdo]

/retest

[enxebre]

Failing because of https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-api-provider-aws/471/pull-ci-openshift-cluster-api-provider-aws-master-e2e-hypershift/1727352562639704064
openshift/hypershift#3227

Should go green now
/test e2e-hypershift

[JoelSpeed]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed,damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[damdo]

/unhold

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-api-container-v4.15.0-202311271455.p0.ga11fc8f.assembly.stream for distgit ose-cluster-api.
All builds following this will include this PR.