run e2e with Ginkgo #59

ingvagabund · 2018-09-27T16:39:36Z

$ go test -v sigs.k8s.io/cluster-api-provider-aws/test/machines -kubeconfig /home/jchaloup/Projects/src/dev/src/sigs.k8s.io/cluster-api-provider-aws/kubeconfig -ginkgo.v
=== RUN   TestCart
Running Suite: Machine Suite
============================
Random Seed: 1538066032
Will run 1 of 1 specs

[sigs.k8s.io] Machines AWS actuator 
  Can create AWS instances
  /home/jchaloup/Projects/src/dev/src/sigs.k8s.io/cluster-api-provider-aws/test/machines/machines_test.go:172
STEP: Creating a kubernetes client
STEP: Creating a kubernetes client
STEP: Deploy cluster API stack components
STEP: Waiting for secrets to appear
STEP: Waiting for cluster API stack to come up
time="2018-09-27T18:33:56+02:00" level=info msg="Waiting for all cluster-api deployment pods to be ready, have 1, expecting 1" source="machines_test.go:105"
STEP: Cluster API stack deployed
STEP: Creating "namespace-212f3614-c273-11e8-a65a-507b9deefa09" namespace
STEP: Creating "cluster-212f364e-c273-11e8-a65a-507b9deefa09" cluster
STEP: Destroying "namespace-212f3614-c273-11e8-a65a-507b9deefa09" namespace

• [SLOW TEST:21.712 seconds]
[sigs.k8s.io] Machines
/home/jchaloup/Projects/src/dev/src/sigs.k8s.io/cluster-api-provider-aws/test/framework/framework.go:97
  AWS actuator
  /home/jchaloup/Projects/src/dev/src/sigs.k8s.io/cluster-api-provider-aws/test/machines/machines_test.go:170
    Can create AWS instances
    /home/jchaloup/Projects/src/dev/src/sigs.k8s.io/cluster-api-provider-aws/test/machines/machines_test.go:172
------------------------------

Ran 1 of 1 Specs in 21.713 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestCart (21.71s)
PASS
ok  	sigs.k8s.io/cluster-api-provider-aws/test/machines	21.752s

[1] https://onsi.github.io/gomega/
[2] https://onsi.github.io/ginkgo/
[3] https://semaphoreci.com/community/tutorials/getting-started-with-bdd-in-go-using-ginkgo

enxebre · 2018-09-27T17:32:28Z

test/utils/utils.go

+	keyName := "libra"
+	publicIP := true
+	amiID := "ami-a9acbbd6"
+	iamInstanceProfileID := "openshift_master_launch_instances"


can we move this to something known we precreate i.e "${var.enviroment_id}-worker-profile"

enxebre · 2018-09-27T17:34:18Z

test/utils/utils.go

+}
+
+func TestingMachine(awsCredentialsSecretName string, clusterID string, namespace string) *clusterv1alpha1.Machine {
+	keyName := "libra"


probably want to remove ssh key for now. It's not being pre-created by infra.tf and might be problematic to create in some accounts. Plus we are adding ssh in a cloud agnostic way via config on the installer/mao

ingvagabund · 2018-09-28T10:52:31Z

/test e2e

ingvagabund · 2018-09-28T11:28:24Z

/test e2e

ingvagabund · 2018-09-28T12:41:32Z

/retest

openshift-ci-robot · 2018-09-28T12:44:40Z

@ingvagabund: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/golint	`a34408f`	link	`/test golint`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ingvagabund · 2018-09-28T12:53:39Z

ci/prow/golint is failing due to:

hack/go-lint.sh -min_confidence 0.3 $(go list -f '{{ .ImportPath }}' ./... | grep -v 'sigs.k8s.io/cluster-api-provider-aws/test')
/go/src/sigs.k8s.io/cluster-api-provider-aws/cloud/aws/actuators/machine/actuator.go:100:21: error strings should not be capitalized or end with punctuation or a newline
/go/src/sigs.k8s.io/cluster-api-provider-aws/cmd/aws-actuator/main.go:180:26: error strings should not be capitalized or end with punctuation or a newline
/go/src/sigs.k8s.io/cluster-api-provider-aws/cmd/aws-actuator/main.go:194:26: error strings should not be capitalized or end with punctuation or a newline
/go/src/sigs.k8s.io/cluster-api-provider-aws/cmd/aws-actuator/main.go:204:26: error strings should not be capitalized or end with punctuation or a newline
/go/src/sigs.k8s.io/cluster-api-provider-aws/cmd/aws-actuator/main.go:218:26: error strings should not be capitalized or end with punctuation or a newline
/go/src/sigs.k8s.io/cluster-api-provider-aws/cmd/aws-actuator/main.go:228:26: error strings should not be capitalized or end with punctuation or a newline
/go/src/sigs.k8s.io/cluster-api-provider-aws/cmd/aws-actuator/main.go:232:26: error strings should not be capitalized or end with punctuation or a newline
/go/src/sigs.k8s.io/cluster-api-provider-aws/cmd/aws-actuator/main.go:242:26: error strings should not be capitalized or end with punctuation or a newline
/go/src/sigs.k8s.io/cluster-api-provider-aws/cmd/aws-actuator/main.go:245:26: error strings should not be capitalized or end with punctuation or a newline
/go/src/sigs.k8s.io/cluster-api-provider-aws/cmd/aws-actuator/main.go:473:23: error strings should not be capitalized or end with punctuation or a newline
Found 10 lint suggestions; failing.

I will fix the lint failures in upcoming PR. I have already updated the Jenkins Job so unless this PR is merged, any other PR will fail.

enxebre · 2018-09-28T13:00:20Z

/lgtm
cool, lets make sure we fix new lint in a follow up

openshift-ci-robot · 2018-09-28T13:00:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [enxebre,ingvagabund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot requested review from frobware and spangenberg September 27, 2018 16:39

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 27, 2018

enxebre reviewed Sep 27, 2018

View reviewed changes

openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 28, 2018

ingvagabund added 2 commits September 28, 2018 14:26

Run e2e with Ginkgo

a89ebc6

Update vendor

a34408f

openshift-ci-robot assigned enxebre Sep 28, 2018

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2018

ingvagabund merged commit a4495a3 into openshift:master Sep 28, 2018

ingvagabund deleted the use-ginkgo-as-a-testing-framework branch September 28, 2018 13:00

ingvagabund changed the title ~~WIP: run e2e with Ginkgo~~ run e2e with Ginkgo Sep 28, 2018

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2018

This was referenced Sep 28, 2018

Add e2e test #47

Closed

Move the create-test-verify code in the CI into go binary #29

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

run e2e with Ginkgo #59

run e2e with Ginkgo #59

ingvagabund commented Sep 27, 2018 •

edited

Loading

enxebre Sep 27, 2018

enxebre Sep 27, 2018 •

edited

Loading

ingvagabund commented Sep 28, 2018

ingvagabund commented Sep 28, 2018

ingvagabund commented Sep 28, 2018

openshift-ci-robot commented Sep 28, 2018 •

edited

Loading

ingvagabund commented Sep 28, 2018

enxebre commented Sep 28, 2018

openshift-ci-robot commented Sep 28, 2018

run e2e with Ginkgo #59

run e2e with Ginkgo #59

Conversation

ingvagabund commented Sep 27, 2018 • edited Loading

enxebre Sep 27, 2018

Choose a reason for hiding this comment

enxebre Sep 27, 2018 • edited Loading

Choose a reason for hiding this comment

ingvagabund commented Sep 28, 2018

ingvagabund commented Sep 28, 2018

ingvagabund commented Sep 28, 2018

openshift-ci-robot commented Sep 28, 2018 • edited Loading

ingvagabund commented Sep 28, 2018

enxebre commented Sep 28, 2018

openshift-ci-robot commented Sep 28, 2018

ingvagabund commented Sep 27, 2018 •

edited

Loading

enxebre Sep 27, 2018 •

edited

Loading

openshift-ci-robot commented Sep 28, 2018 •

edited

Loading