-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-2581: Fix go list for go1.18 #264
OCPBUGS-2581: Fix go list for go1.18 #264
Conversation
@lobziik: This pull request references Jira Issue OCPBUGS-2581, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lobziik: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Specify 'concrete' version of sigs.k8s.io/cluster-api-provider-{aws|azure} which makes go to make a correct replace in `modules.txt` file.
/lgtm |
@JoelSpeed It's alarming to me that we're having to make code changes to support a build infrastructure issue related to Go 1.18 when this branch must be built with 1.15. I'm trying to get to the bottom of that with ART but is not having this merged blocking something else from shipping? |
My understanding was that this is blocking 4.9.z nightlies from being built, which seemed pretty important to fix. If that's not correct then I'm less rushed about merging this |
/lgtm |
@lobziik: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@lobziik: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-2581 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-azure-machine-controllers-container-v4.9.0-202311250023.p0.g0593687.assembly.stream for distgit ose-azure-machine-controllers. |
Specify 'concrete' version of
sigs.k8s.io/cluster-api-provider-{aws|azure}
which makes go to make a correct replace in
modules.txt
file.