UPSTREAM: <carry>: openshift: Set machine addresses #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
frobware
reviewed
May 30, 2019
frobware
reviewed
May 30, 2019
frobware
reviewed
May 30, 2019
frobware
reviewed
May 30, 2019
ingvagabund
force-pushed
the
set-machine-addresses-in-status
branch
from
bd87320
to
a10e9d9
Compare
openshift-ci-robot
added
size/L
ingvagabund
force-pushed
the
set-machine-addresses-in-status
branch
from
a10e9d9
to
c3ba49d
Compare
openshift-ci-robot
added
size/M
Set hostname, private IP, public IP and external DNS name in machine.Status.Addresses. The list of addresses is needed to approve a node and link a node with it's corresponding machine.
ingvagabund
force-pushed
the
set-machine-addresses-in-status
branch
from
c3ba49d
to
510df7b
Compare
|
/lgtm |
frobware
reviewed
May 31, 2019
frobware
reviewed
May 31, 2019
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Danil-Grigorev
pushed a commit
to Danil-Grigorev/cluster-api-provider-azure
that referenced
this pull request
Jan 24, 2020
Add namespace flag to controller command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set hostname, private IP, public IP and external DNS name in machine.Status.Addresses.
The list of addresses is needed to approve a node and link a node with
it's corresponding machine.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: