Convert create into async #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
frobware
reviewed
May 29, 2019
| klog.Infof("Machine %q already exists", r.machine.Name) | ||
| return true, nil | ||
| switch instance.Status { | ||
| case "PROVISIONING", "REPAIRING", "RUNNING", "STAGING": |
There was a problem hiding this comment.
I wonder whether this should be inverted:
switch instance.Status {
case "TERMINATED":
klog.Infof("Machine %q is considered as non existent as its status is %q", instance.Status)
return false, nil
default:
klog.Infof("Machine %q already exists", r.machine.Name)
return true, nil
}There was a problem hiding this comment.
we should make all explicit and error otherwise
There was a problem hiding this comment.
we should make all explicit and error otherwise
This becomes brittle. We only really care for the TERMINATED state.
RadekManak
pushed a commit
to RadekManak/cluster-api-provider-gcp
that referenced
this pull request
Apr 12, 2023
🌱Remove vendor from gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mimics aws behaviour for async creation by relying on the
instance.Status.Staging:
Running:
Logs reflects the machine going from provisioning->staging->running: