Delete Machine when BareMetalHost is deleted #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to ensure a new Machine is created by the MachineSet controller and that it will contain the latest ProviderSpec. Signed-off-by: Richard Su rwsu@redhat.com
openshift-ci-robot
added
the
size/L
mhrivnak
suggested changes
Feb 22, 2020
Signed-off-by: Richard Su <rwsu@redhat.com>
Also, when adding the finalizer, checks to see one doesn't already exist. Signed-off-by: Richard Su <rwsu@redhat.com>
Signed-off-by: Richard Su <rwsu@redhat.com>
Signed-off-by: Richard Su <rwsu@redhat.com>
Signed-off-by: Richard Su <rwsu@redhat.com>
mhrivnak
reviewed
Feb 27, 2020
| // When finalizer for BHM is removed but an error occur before | ||
| // the Machine is deleted below in the StateDeleting block, the | ||
| // Machine should be deleted when no host is found. | ||
| log.Print("Deleting machine associated with no host: ", machine.Name) |
There was a problem hiding this comment.
nit: I'd change this (and the one a few lines below) to "Deleting machine whose associated host is gone." to keep it clear that we don't delete Machines just because they don't have a host.
Message should say the machine is being deleted because the associated host is gone. Signed-off-by: Richard Su <rwsu@redhat.com>
mhrivnak
approved these changes
Feb 28, 2020
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhrivnak, rwsu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
honza
pushed a commit
to honza/cluster-api-provider-baremetal
that referenced
this pull request
Feb 7, 2022
🐛 Multiple updates operation on the BMH openshift#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure a new Machine is created by the MachineSet
controller and that it will contain the latest ProviderSpec.
Signed-off-by: Richard Su rwsu@redhat.com