Don't wait for Host deprovisioning to delete Machine

[zaneb]

If the Host is marked for deletion, don't wait for deprovisioning to
complete (and hence the provisioning status to move to Deleting) before
also marking the Machine for deletion.

Fixes #56

[openshift-ci-robot]

Hi @zaneb. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zaneb]

/assign @mhrivnak
/cc @rwsu

[rwsu]

I like the optimization of using the deletionTimestamp, instead of waiting for the Deleting state. One suggestion is to change the test case names. Other than that, it looks good to me.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zaneb
To complete the pull request process, please assign mhrivnak
You can assign the PR to them by writing /assign @mhrivnak in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mhrivnak]

/ok-to-test

[mhrivnak]

Per my comment on the issue, I don't think this change will fix the described problem. Generally, I'm not seeing how deleting the Machine sooner in the workflow is advantageous.

[openshift-ci-robot]

@zaneb: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-metal-ipi	4eaa2b8	link	/test e2e-metal-ipi

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dhellmann]

Per my comment on the issue, I don't think this change will fix the described problem. Generally, I'm not seeing how deleting the Machine sooner in the workflow is advantageous.

Maybe the thing to do is add the appropriate annotation as soon as the host is marked as being deleted, and then actually delete the machine after the host is deprovisioned (if the machineset controller hasn't already started to delete it).

[dhellmann]

See #87

[zaneb]

I'm working on a more comprehensive solution to the problem, so closing this.
/close

[openshift-ci-robot]

@zaneb: Closed this PR.

In response to this:

I'm working on a more comprehensive solution to the problem, so closing this.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.