ensure delete removes the link between machine and host #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
|
/retest |
zaneb
reviewed
Jul 20, 2020
kirankt
reviewed
Jul 20, 2020
zaneb
reviewed
Jul 21, 2020
We were not removing the host annotation from the machine, which made it appear to always be deleting. This change reorganizes the Delete() function in the actuator to ensure that all of the progressive steps of deprovisioning the host and then removing both links between the machine and host are handled. https://bugzilla.redhat.com/show_bug.cgi?id=1855823 Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
honza
pushed a commit
to honza/cluster-api-provider-baremetal
that referenced
this pull request
Feb 7, 2022
🐛 Update BMO dependency for root device hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not removing the host annotation from the machine, which made
it appear to always be deleting. This change reorganizes the Delete()
function in the actuator to ensure that all of the progressive steps
of deprovisioning the host and then removing both links between the
machine and host are handled.
https://bugzilla.redhat.com/show_bug.cgi?id=1855823