[OCPCLOUD-1044] Bug 1902157: Update termination handler to use node conditions #134
Conversation
pkg/termination/termination.go
Outdated
| logger.V(1).Info("Instance marked for termination, marking Machine for deletion") | ||
| if err := h.markNodeForDeletion(ctx); err != nil { | ||
| return fmt.Errorf("error marking machine: %v", err) |
There was a problem hiding this comment.
This is saying to mark the machine, needs to say to mark the node
|
/retitle [OCPCLOUD-1044] Bug 1902157: Update termination handler to use node conditions |
openshift-ci-robot
changed the title
|
@alexander-demichev: This pull request references Bugzilla bug 1902157, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-medium
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@alexander-demichev: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1902157 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Switch from deleting the Machine to marking the Node with a Terminating condition.
This will integrate with an MHC to ensure that the Machine is deleted.
This should be possible using the Node's credentials and as such, the termination handler will not need its own credentials and extra permissions.
Requires openshift/machine-api-operator#627 before it will work
openshift/cluster-api-provider-aws#332