New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OCPCLOUD-1066] Makefile fix #147

Merged

openshift-merge-robot merged 3 commits into openshift:master from SamuelStuchly:OCPCLOUD-1066-makefiles

Jun 14, 2021

Contributor

SamuelStuchly commented Feb 10, 2021 •

edited

Loading

Fixed broken Makefile targets.
Added script to fix permission issues.
Updated Readme.
Update .gitignore.

openshift-ci-robot requested review from alexander-demicev and elmiko

February 10, 2021 11:34

SamuelStuchly changed the title ~~[OCPCLOUD-1066] Makefile fix~~ WIP: [OCPCLOUD-1066] Makefile fix

openshift-ci-robot added the do-not-merge/work-in-progress label

SamuelStuchly changed the title ~~WIP: [OCPCLOUD-1066] Makefile fix~~ [OCPCLOUD-1066] Makefile fix

openshift-ci-robot removed the do-not-merge/work-in-progress label

SamuelStuchly force-pushed the OCPCLOUD-1066-makefiles branch from 983902d to d1f61e5 Compare

February 11, 2021 15:17

elmiko approved these changes

View reviewed changes

Contributor

elmiko left a comment

tested out locally, worked as expected. one minor nit
/approve

Makefile Outdated

+              USE_DOCKER ?= 0
+              ifeq ($(USE_DOCKER), 1)
+              	ENGINE=docker

Contributor

elmiko Mar 2, 2021

extra spaces after docker

Contributor

openshift-ci-robot commented Mar 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [elmiko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the approved label

SamuelStuchly force-pushed the OCPCLOUD-1066-makefiles branch from d1f61e5 to 53d1012 Compare

March 5, 2021 09:40

Contributor Author

SamuelStuchly commented Mar 11, 2021

/retest

9 similar comments

Contributor Author

SamuelStuchly commented Mar 11, 2021

/retest

Contributor Author

SamuelStuchly commented Mar 16, 2021

/retest

Contributor Author

SamuelStuchly commented Mar 16, 2021

/retest

Contributor Author

SamuelStuchly commented Mar 19, 2021

/retest

Contributor Author

SamuelStuchly commented Mar 19, 2021

/retest

Contributor Author

SamuelStuchly commented Mar 21, 2021

/retest

Contributor Author

SamuelStuchly commented Mar 22, 2021

/retest

Contributor Author

SamuelStuchly commented Mar 23, 2021

/retest

Contributor Author

SamuelStuchly commented Mar 26, 2021

/retest

elmiko approved these changes

View reviewed changes

Contributor

elmiko left a comment

/lgtm

openshift-ci-robot assigned elmiko

openshift-ci-robot added the lgtm label

Contributor

openshift-bot commented Mar 26, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments

Contributor

openshift-bot commented Mar 26, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments

Contributor

openshift-bot commented Apr 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 30, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci bot added the needs-rebase label


          Update make targets to run with podman and docker or without container

6f8480f

SamuelStuchly force-pushed the OCPCLOUD-1066-makefiles branch from 53d1012 to f5be73a Compare

May 13, 2021 10:06

openshift-ci bot removed lgtm needs-rebase labels

Contributor

openshift-ci bot commented May 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [elmiko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor Author

SamuelStuchly commented May 20, 2021

/retest

1 similar comment

Contributor Author

SamuelStuchly commented May 21, 2021

/retest

JoelSpeed reviewed

View reviewed changes

Contributor

JoelSpeed left a comment

Couple of nits, otherwise this LGTM

.gitignore Outdated

+              # IDE configs
+              .idea/
+              .vscode/

Contributor

JoelSpeed May 24, 2021

It's convention to leave a blank new line at the end of every file, please make sure your IDE is set up to do this (this is the red marker on this line that shows it's missing)

hack/owner_reset.sh Outdated


		sudo chown -R $USER bin \
		chown $USER .git/index

Contributor

JoelSpeed May 24, 2021

Whitespace on this line is also confusing it

Suggested change

SamuelStuchly added 2 commits

May 27, 2021 16:08


          Add script for fixing permission issues when running make targets wit…

97cbe39

…h podman


          update .gitignore

38cc464

SamuelStuchly force-pushed the OCPCLOUD-1066-makefiles branch from f5be73a to 38cc464 Compare

May 27, 2021 14:08

Contributor Author

SamuelStuchly commented Jun 2, 2021

/retest

1 similar comment

Contributor Author

SamuelStuchly commented Jun 7, 2021

/retest

Contributor

JoelSpeed commented Jun 9, 2021

/lgtm

openshift-ci bot assigned JoelSpeed

openshift-ci bot added the lgtm label

openshift-merge-robot merged commit dfb55f4 into openshift:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels