"OCPBUGS-17476: Add workaround for SLOF regression" #263
Conversation
When adding a console to libvirt XML definition, it's a virtio-console which is added. This triggered an unrelated regression on ppc64le https://issues.redhat.com/browse/OCPBUGS-17476 This commit lets libvirt uses its preferred device for the console depending on the platform. On ppc64le, this should correspond to spapr devices. This should workaround https://issues.redhat.com/browse/OCPBUGS-17476
After the switch from spice to VNC, we no longer need the virConnect argument to newDomain()
|
@cfergeau: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign @cfergeau |
|
I tested this on a beaker ppc64le machine, and the worker nodes could get an IP, and I could ssh into them. |
|
/lgtm |
|
/lgtm |
|
/approved |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cherrypick release-4.13 |
|
/cherrypick release-4.14 |
|
@mkumatag: new pull request created: #264 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mkumatag: new pull request created: #265 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle "OCPBUGS-17476: Add workaround for SLOF regression" |
openshift-ci
bot
changed the title
|
@cfergeau: Jira Issue OCPBUGS-17476: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-17476 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-libvirt-machine-controllers-container-v4.15.0-202311202349.p0.g43b2b82.assembly.stream for distgit ose-libvirt-machine-controllers. |
A SLOF regression in rhel 8.6 prevents OpenShift libvirt worker nodes from booting.
It's easy to workaround if the VM has a serial (non-virtio) device, so this PR tries to add one.