Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"OCPBUGS-17476: Add workaround for SLOF regression" #263

Merged
merged 2 commits into from Sep 27, 2023
Merged

"OCPBUGS-17476: Add workaround for SLOF regression" #263

merged 2 commits into from Sep 27, 2023

Commits on Sep 19, 2023

  1. libvirt: Don't force of use virtio console 

    When adding a console to libvirt XML definition, it's a virtio-console
which is added. This triggered an unrelated regression on ppc64le
https://issues.redhat.com/browse/OCPBUGS-17476

This commit lets libvirt uses its preferred device for the console
depending on the platform. On ppc64le, this should correspond to spapr
devices.

This should workaround https://issues.redhat.com/browse/OCPBUGS-17476
    @cfergeau
    cfergeau committed Sep 19, 2023
    Copy the full SHA
    4a9f25f View commit details
    Browse the repository at this point in the history

  2. Remove unused arg 

    After the switch from spice to VNC, we no longer need the virConnect
argument to newDomain()
    @cfergeau
    cfergeau committed Sep 19, 2023
    Copy the full SHA
    d2871e8 View commit details
    Browse the repository at this point in the history