Bug 1883497: Fix missing logs due to mixed klog versions #130
Conversation
openshift-ci-robot
added
bugzilla/severity-high
|
@JoelSpeed: This pull request references Bugzilla bug 1883497, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@JoelSpeed: This pull request references Bugzilla bug 1883497, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold I need to do some additional fixes to this |
openshift-ci-robot
added
the
do-not-merge/hold
JoelSpeed
force-pushed
the
mao-update-6abfb544
branch
from
461f812
to
787d62c
Compare
|
/hold cancel This should be good for review now, all klog v1 is now gone from this repo :) |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
@alexander-demichev: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demichev, pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
|
@JoelSpeed: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1883497 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This makes klog consistent with the core of the Kubernetes project (as of v1.19) which used klog/v2.
While on differing versions we will lose logs (only one version will bind the correct flag value) so we should upgrade to v2 to ensure all logs are being printed correctly.