bump(*) #72
Merged
bump(*) #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
|
/hold |
Fedosin
force-pushed
the
vendor_bump
branch
4 times, most recently
from
4dfb919
to
579841c
Compare
|
/test e2e-openstack |
|
/retest |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
Yeah! Unit tests pass now |
clusterctl was deprecated and we've never used it in CAPO. In openshift/cluster-api 4.3 it was removed from the tree, so we need to do the same to upgrade capo to 4.3.
We use this function but unfortunately it was removed from cluster-api in 4.3. So, to cintinue using it we have to move the code directly to capo.
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, iamemilio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrades cluster-api to 4.3 and k8s libs to 1.16