Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1832832: Fix disk extension #47

Merged
merged 1 commit into from
May 10, 2020
Merged

Bug 1832832: Fix disk extension #47

merged 1 commit into from
May 10, 2020

Conversation

rgolangh
Copy link

@rgolangh rgolangh commented May 7, 2020

Disk extension was failing because of wrong API usage.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2020
@rgolangh
Copy link
Author

rgolangh commented May 7, 2020

@bennyz PTAL

@rgolangh rgolangh changed the title Fix disk extension Bug 1832832: Fix disk extension May 7, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label May 7, 2020
@openshift-ci-robot
Copy link

@rgolangh: This pull request references Bugzilla bug 1832832, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1832832: Fix disk extension

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 7, 2020
@rgolangh
Copy link
Author

rgolangh commented May 7, 2020

/bugzilla-refresh

Gal-Zaidman
Gal-Zaidman reviewed May 7, 2020
View reviewed changes
pkg/cloud/ovirt/clients/machineservice.go
}

size := getDisk.MustDisk().MustProvisionedSize()
if newDiskSize > size {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a elif newDiskSize < size --> log that shrinking is not supported

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rgolangh
Fix disk extension
44b2c66 
Disk extension was failing because of wrong API usage.

Signed-off-by: Roy Golan <rgolan@redhat.com>
@Gal-Zaidman
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gal-Zaidman, rgolangh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9920280 into openshift:master May 10, 2020
@openshift-ci-robot
Copy link

@rgolangh: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-ovirt#47. Bugzilla bug 1832832 has been moved to the MODIFIED state.

In response to this:

Bug 1832832: Fix disk extension

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rgolangh
Copy link
Author

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@rgolangh: #47 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/cloud/ovirt/clients/machineservice.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/cloud/ovirt/clients/machineservice.go
CONFLICT (content): Merge conflict in pkg/cloud/ovirt/clients/machineservice.go
Patch failed at 0001 Fix disk extension

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gal-Zaidman Gal-Zaidman Gal-Zaidman left review comments

Assignees

@Gal-Zaidman Gal-Zaidman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rgolangh @openshift-ci-robot @Gal-Zaidman @openshift-cherrypick-robot @openshift-merge-robot