add custom capo readme #88
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gal-Zaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
docs/custom-capo.md
Outdated
| When we develop the CAPO its usually helpful to test it against a running cluster. | ||
| The following doc explains how to do it. | ||
|
|
||
| ## Replacing the docker image |
There was a problem hiding this comment.
I would replace "docker" as container.
docs/custom-capo.md
Outdated
| @@ -0,0 +1,58 @@ | |||
| # Creating a custom cluster api provider ovirt and adding it to the cluster | |||
|
|
|||
| When we develop the CAPO its usually helpful to test it against a running cluster. | |||
There was a problem hiding this comment.
What's CAPO? :) I am assuming is: Cluster API Provider OVirt (CAPO)
I would than use: When we develop the Cluster API Provider oVirt (CAPO) its ....
|
|
||
| 1.Lunch a cluster: | ||
|
|
||
| Start an Openshift cluster on top of oVirt as usual with the required release image. |
There was a problem hiding this comment.
I would like a note here like:
For more info about installing and launching a new cluster using oVirt check:
docs/custom-capo.md
Outdated
|
|
||
| ## Replacing the docker image | ||
|
|
||
| 1.Lunch a cluster: |
docs/custom-capo.md
Outdated
|
|
||
| Start an Openshift cluster on top of oVirt as usual with the required release image. | ||
|
|
||
| 2. Create the docker image: |
docs/custom-capo.md
Outdated
| 4. Replace the CAPO image | ||
|
|
||
| ```bash | ||
| oc -n openshift-machine-api edit configmap/machine-api-operator-images |
| ```bash | ||
| oc -n openshift-machine-api edit configmap/machine-api-operator-images | ||
| ``` | ||
| and replace clusterAPIControllerOvirt with the pull (by digest) of your image |
There was a problem hiding this comment.
Users and devel will ask: How can I find the digest from the my image? Can we add an example here?
docs/custom-capo.md
Outdated
| 5. verify that the image has been replaced: | ||
|
|
||
| ```bash | ||
| oc -n openshift-machine-api get pods |
docs/custom-capo.md
Outdated
| 5. verify that the image has been replaced: | ||
|
|
||
| ```bash | ||
| oc -n openshift-machine-api get pods |
There was a problem hiding this comment.
I would copy/past a real example of the command
Gal-Zaidman
force-pushed
the
add-readme-for-custom-capo
branch
from
134159d
to
3853b10
Compare
|
@Gal-Zaidman: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
documentation only |
No description provided.