Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1939358: extract node machine ipaddress from the engine instead using DNS . #98

Merged
merged 1 commit into from
Apr 9, 2021
Merged

[release-4.7] Bug 1939358: extract node machine ipaddress from the engine instead using DNS . #98

merged 1 commit into from
Apr 9, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #85

/assign Gal-Zaidman

@eslutsky
WIP: extract node machine ipaddress from the engine instead using dns…
bb4ba73 
…lookup

dnslookup was a temp solution until qemu-agent will be integrated into the rchos,
this change remove  dnslookup and replace it with oVirt SDK call for the node ip address extraction.

this patch introduces the following changes:
- get APIServerInternalIP from the API  configuration
  we will use that address for filtering nodeIP address
- use nic regex naming convention to filter irrelevant interface devices
- get ingressIPAddress from the API configuration
- exclude AIPVip and ingress address from address election proccess
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 16, 2021
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Bugzilla bug 1920905 has been cloned as Bugzilla bug 1939358. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1939358: extract node machine ipaddress from the engine instead using DNS .

In response to this:

[release-4.7] Bug 1920905: extract node machine ipaddress from the engine instead using DNS .

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.7] Bug 1920905: extract node machine ipaddress from the engine instead using DNS . [release-4.7] Bug 1939358: extract node machine ipaddress from the engine instead using DNS . Mar 16, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 16, 2021
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1939358, which is invalid:

  • expected dependent Bugzilla bug 1920905 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1939358: extract node machine ipaddress from the engine instead using DNS .

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gal-Zaidman
Copy link

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gal-Zaidman, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2021
@Gal-Zaidman
Copy link

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 30, 2021
@openshift-ci-robot
Copy link

@Gal-Zaidman: This pull request references Bugzilla bug 1939358, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1920905 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1920905 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (mburman@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@russellb russellb added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit 01b9bf8 into openshift:release-4.7 Apr 9, 2021
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1939358 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1939358: extract node machine ipaddress from the engine instead using DNS .

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennyz bennyz Awaiting requested review from bennyz

@Gal-Zaidman Gal-Zaidman Awaiting requested review from Gal-Zaidman

Assignees

@Gal-Zaidman Gal-Zaidman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @Gal-Zaidman @russellb @openshift-merge-robot @eslutsky