NO-JIRA: Merge https://github.com/kubernetes-sigs/cluster-api:v1.6.2 (da795db) into master #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Shen <mishen@umich.edu>
…ot/cherry-pick-9767-to-release-1.6 [release-1.6] 📖 add release 1.5 book link
…ot/cherry-pick-9801-to-release-1.6 [release-1.6] 📖 Update clusterctl version to v1.6.x in quick start
Replace env.Create and env.Cleanup with env.CreateAndWait and env.CleanupAndWait, remove namespace from cleanup.
Signed-off-by: Anurag <contact.anurag7@gmail.com>
…t before continuing
…ot/cherry-pick-9817-to-release-1.6 [release-1.6] 📖 Set 1.4 EOL date and update coredns version table
…ot/cherry-pick-9745-to-release-1.6 [release-1.6] 🐛 Fix TestReconcileMachinePoolScaleToFromZero flakes
…ot/cherry-pick-9819-to-release-1.6 [release-1.6] 🐛 test: wait for topology to get rolled out before continuing with scaling checks
…ot/cherry-pick-9829-to-release-1.6 [release-1.6] 🌱 Add proxmox to provider list
…ot/cherry-pick-9808-to-release-1.6 [release-1.6] 🐛 clusterctl: validate no objects exist from CRDs before deleting them
Signed-off-by: Stefan Büringer buringerst@vmware.com
…ot/cherry-pick-9840-to-release-1.6 [release-1.6] 🌱 Bump to Go 1.20.12
…ot/cherry-pick-9861-to-release-1.6 [release-1.6] 🐛 ipam: fix webhooks using mixed api versions
…ot/cherry-pick-9876-to-release-1.6 [release-1.6] 🌱 Update glossary.md: Fix typo in level of heading.
…ot/cherry-pick-9813-to-release-1.6 [release-1.6] 🐛 Improve log k/v pairs and a improve/drop a few log lines
Signed-off-by: Stefan Büringer buringerst@vmware.com
…ot/cherry-pick-9871-to-release-1.6 [release-1.6] ✨ KCP: Allow mutation of all fields that should be mutable
…ot/cherry-pick-9894-to-release-1.6 [release-1.6] 🐛 capd: fix ignition to also set the kube-proxy configuration to skip setting sysctls
✨ [release-1.6] v1.29: Prepare quickstart, capd and tests for the new release including kind bump
This fixes a race condition in the machine controller when the controller is restarted after a machine has been marked for deletion but before the infra machine or bootstrap config are deleted. In that case, the controller doesn't have watches on those external objects, so the reconciliation is not triggered once they are deleted. This means that Machines stay in Deleting state for the resync period, the default is 10 minutes.
…-machine-controller-release-1.6 [release-1.6] 🐛 Watch external objects for machine before deleting
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
damdo
force-pushed
the
rebase-atop-v1.6.2
branch
from
110aa8a
to
e1992ce
Compare
damdo
changed the title
|
@damdo: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
/retest |
1 similar comment
|
/retest |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-merge-robot
added
the
needs-rebase
damdo
force-pushed
the
rebase-atop-v1.6.2
branch
from
e1992ce
to
9fc67d0
Compare
openshift-merge-robot
removed
the
needs-rebase
damdo
force-pushed
the
rebase-atop-v1.6.2
branch
from
9fc67d0
to
948626b
Compare
|
/retest |
|
@damdo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-api-container-v4.16.0-202403122214.p0.gbb7f378.assembly.stream.el9 for distgit ose-cluster-api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.