Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: add ingress and routes to related objects #210

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Oct 30, 2019

As we see more degraded operators because of broken routing, add ingress, route and service to related objects, so inspect will collect them. Adding the openshift-ingress namespace to related objects means the insights operator will copy out any failing pod in that namespace.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2019
@deads2k
Copy link
Contributor

deads2k commented Oct 30, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
@openshift-merge-robot openshift-merge-robot merged commit 00cf014 into openshift:master Oct 30, 2019
@openshift-cherrypick-robot

@mfojtik: cannot checkout 4.2: error checking out 4.2: exit status 1. output: error: pathspec '4.2' did not match any file(s) known to git.

In response to this:

/cherrypick 4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Contributor Author

mfojtik commented Nov 15, 2019

/cherrypick release-4.2

@openshift-cherrypick-robot

@mfojtik: new pull request created: #217

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants