New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.9] Bug 2062292: e2e: Pin Keycloack to the legacy variant #556
[release-4.9] Bug 2062292: e2e: Pin Keycloack to the legacy variant #556
Conversation
In v17, the Keycloak container image introduced several breaking changes to the API[1], and most notably: * a keycloak container won't start by default; it needs a `start` or `start-dev` command * the `auth` part of the API path has been removed * server configuration has changed This patch pins the test suite to the "legacy" variant of the Keycloak 17.0.0 image, which is backwards-compatible. Before this patch, and because this repository was not pinning the Keycloak version, e2e tests fail with: FAIL: TestKeycloakAsOIDCPasswordGrantCheck [1]: https://www.keycloak.org/migration/migrating-to-quarkus
@openshift-cherrypick-robot: Bugzilla bug 2060473 has been cloned as Bugzilla bug 2062292. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2062292, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
/assign stlaz |
@pierreprinetti: This pull request references Bugzilla bug 2062292, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@pierreprinetti: This pull request references Bugzilla bug 2062292, which is valid. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (pprinett@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
only tests, overriding labels |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 2062292 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.8 |
@pierreprinetti: new pull request created: #557 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #555
/assign pierreprinetti