Bug 2060473: e2e: Pin Keycloack to the legacy variant #555
Conversation
In v17, the Keycloak container image introduced several breaking changes
to the API[1], and most notably:
* a keycloak container won't start by default; it needs a `start` or
`start-dev` command
* the `auth` part of the API path has been removed
* server configuration has changed
This patch pins the test suite to the "legacy" variant of the Keycloak
17.0.0 image, which is backwards-compatible.
Before this patch, and because this repository was not pinning the
Keycloak version, e2e tests fail with:
FAIL: TestKeycloakAsOIDCPasswordGrantCheck
[1]: https://www.keycloak.org/migration/migrating-to-quarkus
openshift-ci
bot
added
bugzilla/severity-medium
|
@pierreprinetti: This pull request references Bugzilla bug 2060473, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.9 |
|
@pierreprinetti: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pierreprinetti: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
stlaz
added
bugzilla/valid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
this is only tests, I am going to override all the labels. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
mfojtik
added
the
staff-eng-approved
|
@pierreprinetti: All pull requests linked via external trackers have merged: Bugzilla bug 2060473 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pierreprinetti: new pull request created: #556 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In v17, the Keycloak container image introduced several breaking changes
to the API1, and most notably:
startorstart-devcommandauthpart of the API path has been removedThis patch pins the test suite to the "legacy" variant of the Keycloak
17.0.0 image, which is backwards-compatible.
Before this patch, and because this repository was not pinning the
Keycloak version, e2e tests fail with: